|
From: | Shivam Kumar |
Subject: | Re: [RFC PATCH 1/1] Dirty quota-based throttling of vcpus |
Date: | Tue, 22 Nov 2022 09:30:14 +0530 |
User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 |
On 21/11/22 5:05 pm, Philippe Mathieu-Daudé wrote:
Hi, On 20/11/22 23:54, Shivam Kumar wrote:+ +void dirty_quota_migration_start(void) +{ + if (!kvm_state->dirty_quota_supported) {You are accessing an accelerator-specific variable in an accelerator-agnostic file, this doesn't sound correct.You might introduce some hooks in AccelClass and implement them in accel/kvm/. See for example gdbstub_supported_sstep_flags() and kvm_gdbstub_sstep_flags().
Ack. Thanks, Shivam
[Prev in Thread] | Current Thread | [Next in Thread] |