[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 8/8] virtio: disable error for out of spec queue-enable
From: |
Michael S. Tsirkin |
Subject: |
[PULL 8/8] virtio: disable error for out of spec queue-enable |
Date: |
Tue, 22 Nov 2022 05:23:45 -0500 |
Virtio 1.0 is pretty clear that features have to be
negotiated before enabling VQs. Unfortunately Seabios
ignored this ever since gaining 1.0 support (UEFI is ok).
Comment the error out for now, and add a TODO.
Fixes: 3c37f8b8d1 ("virtio: introduce virtio_queue_enable()")
Cc: "Kangjie Xu" <kangjie.xu@linux.alibaba.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Message-Id: <20221121200339.362452-1-mst@redhat.com>
---
hw/virtio/virtio.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 9683b2e158..eb6347ab5d 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -2499,10 +2499,17 @@ void virtio_queue_enable(VirtIODevice *vdev, uint32_t
queue_index)
{
VirtioDeviceClass *k = VIRTIO_DEVICE_GET_CLASS(vdev);
+ /*
+ * TODO: Seabios is currently out of spec and triggering this error.
+ * So this needs to be fixed in Seabios, then this can
+ * be re-enabled for new machine types only, and also after
+ * being converted to LOG_GUEST_ERROR.
+ *
if (!virtio_vdev_has_feature(vdev, VIRTIO_F_VERSION_1)) {
error_report("queue_enable is only suppported in devices of virtio "
"1.0 or later.");
}
+ */
if (k->queue_enable) {
k->queue_enable(vdev, queue_index);
--
MST
- [PULL 0/8] pc,virtio: regression, test fixes, Michael S. Tsirkin, 2022/11/22
- [PULL 1/8] vhost: mask VIRTIO_F_RING_RESET for vhost and vhost-user devices, Michael S. Tsirkin, 2022/11/22
- [PULL 2/8] tests: acpi: whitelist DSDT before moving PRQx to _SB scope, Michael S. Tsirkin, 2022/11/22
- [PULL 3/8] acpi: x86: move RPQx field back to _SB scope, Michael S. Tsirkin, 2022/11/22
- [PULL 4/8] tests: acpi: x86: update expected DSDT after moving PRQx fields in _SB scope, Michael S. Tsirkin, 2022/11/22
- [PULL 5/8] MAINTAINERS: add mst to list of biosbits maintainers, Michael S. Tsirkin, 2022/11/22
- [PULL 6/8] tests/avocado: configure acpi-bits to use avocado timeout, Michael S. Tsirkin, 2022/11/22
- [PULL 7/8] acpi/tests/avocado/bits: keep the work directory when BITS_DEBUG is set in env, Michael S. Tsirkin, 2022/11/22
- [PULL 8/8] virtio: disable error for out of spec queue-enable,
Michael S. Tsirkin <=
- Re: [PULL 0/8] pc,virtio: regression, test fixes, Stefan Hajnoczi, 2022/11/22