Re: [PATCH for-8.0 17/29] tcg/aarch64: Add have_lse, have_lse2

[Philippe Mathieu-Daudé]

On 22/11/22 00:10, Philippe Mathieu-Daudé wrote:
> On 18/11/22 10:47, Richard Henderson wrote:
> > Notice when the host has additional atomic instructions.
> > The new variables will also be used in generated code.
> >
> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> > ---
> >   tcg/aarch64/tcg-target.h     |  3 +++
> >   tcg/aarch64/tcg-target.c.inc | 10 ++++++++++
> >   2 files changed, 13 insertions(+)
>
>
> > diff --git a/tcg/aarch64/tcg-target.c.inc b/tcg/aarch64/tcg-target.c.inc
> > index 001a71bbc0..cf5ee6f742 100644
> > --- a/tcg/aarch64/tcg-target.c.inc
> > +++ b/tcg/aarch64/tcg-target.c.inc
> > @@ -13,6 +13,8 @@
> >   #include "../tcg-ldst.c.inc"
> >   #include "../tcg-pool.c.inc"
> >   #include "qemu/bitops.h"
> > +#include <asm/hwcap.h>
>
> This doesn't build on Darwin:

Project version: 7.1.91
C compiler for the host machine: clang (clang 14.0.0 "Apple clang 
version 14.0.0 (clang-1400.0.29.102)")
C linker for the host machine: clang ld64 819.6
Host machine cpu family: aarch64
Host machine cpu: arm64

> In file included from ../../tcg/tcg.c:426:
> tcg/aarch64/tcg-target.c.inc:16:10: fatal error: 'asm/hwcap.h' file not 
> found
> #include <asm/hwcap.h>
>           ^~~~~~~~~~~~~
>
> In file included from ../../accel/tcg/cputlb.c:1656:
> ../../accel/tcg/ldst_atomicity.c.inc:269:21: warning: value size does 
> not match register size specified by the constraint and modifier 
> [-Wasm-operand-widths]
>              : "=&r"(r.u), "=&r"(fail) : "Q"(*p));
>                      ^