[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 8/8] migration: Block migration comment or code is wrong
From: |
Juan Quintela |
Subject: |
[PULL 8/8] migration: Block migration comment or code is wrong |
Date: |
Mon, 21 Nov 2022 13:59:07 +0100 |
And it appears that what is wrong is the code. During bulk stage we
need to make sure that some block is dirty, but no games with
max_size at all.
Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
---
migration/block.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration/block.c b/migration/block.c
index 3577c815a9..4347da1526 100644
--- a/migration/block.c
+++ b/migration/block.c
@@ -880,8 +880,8 @@ static void block_save_pending(QEMUFile *f, void *opaque,
uint64_t max_size,
blk_mig_unlock();
/* Report at least one block pending during bulk phase */
- if (pending <= max_size && !block_mig_state.bulk_completed) {
- pending = max_size + BLK_MIG_BLOCK_SIZE;
+ if (!pending && !block_mig_state.bulk_completed) {
+ pending = BLK_MIG_BLOCK_SIZE;
}
trace_migration_block_save_pending(pending);
--
2.38.1
- [PULL 0/8] Next patches, Juan Quintela, 2022/11/21
- [PULL 1/8] migration/channel-block: fix return value for qio_channel_block_{readv, writev}, Juan Quintela, 2022/11/21
- [PULL 2/8] migration/multifd/zero-copy: Create helper function for flushing, Juan Quintela, 2022/11/21
- [PULL 3/8] migration: Fix possible infinite loop of ram save process, Juan Quintela, 2022/11/21
- [PULL 4/8] migration: Fix race on qemu_file_shutdown(), Juan Quintela, 2022/11/21
- [PULL 5/8] migration: Disallow postcopy preempt to be used with compress, Juan Quintela, 2022/11/21
- [PULL 6/8] migration: Use non-atomic ops for clear log bitmap, Juan Quintela, 2022/11/21
- [PULL 7/8] migration: Disable multifd explicitly with compression, Juan Quintela, 2022/11/21
- [PULL 8/8] migration: Block migration comment or code is wrong,
Juan Quintela <=
- Re: [PULL 0/8] Next patches, Stefan Hajnoczi, 2022/11/21