[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL v4 46/83] acpi: pc/q35: drop ad-hoc PCI-ISA bridge AML routine
From: |
Igor Mammedov |
Subject: |
Re: [PULL v4 46/83] acpi: pc/q35: drop ad-hoc PCI-ISA bridge AML routines and let bus ennumeration generate AML |
Date: |
Mon, 21 Nov 2022 08:23:15 +0100 |
On Sat, 19 Nov 2022 12:22:13 -0500
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Fri, Nov 18, 2022 at 03:55:17PM +0100, Igor Mammedov wrote:
> > On Fri, 18 Nov 2022 14:08:36 +0100
> > Igor Mammedov <imammedo@redhat.com> wrote:
> >
> > > On Thu, 17 Nov 2022 22:51:46 +0100
> > > Volker Rümelin <vr_qemu@t-online.de> wrote:
> > [...]
> > > > since this patch SeaBIOS no longer detects the PS/2 keyboard. This
> > > > means
> > > > there's no keyboard in SeaBIOS, GRUB or FreeDOS. OVMF and Linux detect
> > > > the PS/2 keyboard without issues.
> > > >
> > > > Here are a few lines from the SeaBIOS debug log.
> > > >
> > > > table(50434146)=0x007e1971 (via rsdt)
> > > > ACPI: parse DSDT at 0x007e0040 (len 6449)
> > > > parse_termlist: parse error, skip from 92/465
> > > > Scan for VGA option rom
> > > > Running option rom at c000:0003
> > > > Start SeaVGABIOS (version rel-1.16.0-0-gd239552ce722-prebuilt.qemu.org)
> > > >
> > > > and later
> > > >
> > > > SeaBIOS (version rel-1.16.0-0-gd239552ce722-prebuilt.qemu.org)
> > > > ACPI: no PS/2 keyboard present
> > it was a bug on SeaBIOS side, we need it to parse Alias term in AML
> > instead of choking on it
> >
> > proposed patch:
> >
> > https://mail.coreboot.org/hyperkitty/list/seabios@seabios.org/thread/RGPL7HESH5U5JRLEO6FP77CZVHZK5J65/
> >
> > PS:
> > it's probably too late for it to make into 7.2
>
> Right. So revert?
let me check first what happens with migration case,
and maybe I can come up with a temporary hack to avoid aliases on QEMU side,
probably it will be something ugly but should do the job
>
- Re: [PULL v4 45/83] tests: acpi: whitelist DSDT before generating PCI-ISA bridge AML automatically, (continued)
[PULL v4 49/83] acpi: add get_dev_aml_func() helper, Michael S. Tsirkin, 2022/11/07
[PULL v4 50/83] acpi: enumerate SMB bridge automatically along with other PCI devices, Michael S. Tsirkin, 2022/11/07
[PULL v4 51/83] tests: acpi: update expected blobs, Michael S. Tsirkin, 2022/11/07
[PULL v4 52/83] tests: acpi: pc/q35 whitelist DSDT before \_GPE cleanup, Michael S. Tsirkin, 2022/11/07
[PULL v4 53/83] acpi: pc/35: sanitize _GPE declaration order, Michael S. Tsirkin, 2022/11/07
[PULL v4 54/83] tests: acpi: update expected blobs, Michael S. Tsirkin, 2022/11/07
[PULL v4 55/83] hw/acpi/erst.c: Fix memory handling issues, Michael S. Tsirkin, 2022/11/07
[PULL v4 56/83] MAINTAINERS: Add qapi/virtio.json to section "virtio", Michael S. Tsirkin, 2022/11/07
[PULL v4 57/83] msix: Assert that specified vector is in range, Michael S. Tsirkin, 2022/11/07