Re: [PULL v4 46/83] acpi: pc/q35: drop ad-hoc PCI-ISA bridge AML routines and let bus ennumeration generate AML

[Michael S. Tsirkin]

On Fri, Nov 18, 2022 at 03:55:17PM +0100, Igor Mammedov wrote:
> On Fri, 18 Nov 2022 14:08:36 +0100
> Igor Mammedov <imammedo@redhat.com> wrote:
> 
> > On Thu, 17 Nov 2022 22:51:46 +0100
> > Volker Rümelin <vr_qemu@t-online.de> wrote:
> [...]
> > > since this patch SeaBIOS no longer detects the PS/2 keyboard. This means 
> > > there's no keyboard in SeaBIOS, GRUB or FreeDOS. OVMF and Linux detect 
> > > the PS/2 keyboard without issues.
> > > 
> > > Here are a few lines from the SeaBIOS debug log.
> > > 
> > > table(50434146)=0x007e1971 (via rsdt)
> > > ACPI: parse DSDT at 0x007e0040 (len 6449)
> > > parse_termlist: parse error, skip from 92/465
> > > Scan for VGA option rom
> > > Running option rom at c000:0003
> > > Start SeaVGABIOS (version rel-1.16.0-0-gd239552ce722-prebuilt.qemu.org)
> > > 
> > > and later
> > > 
> > > SeaBIOS (version rel-1.16.0-0-gd239552ce722-prebuilt.qemu.org)
> > > ACPI: no PS/2 keyboard present  
> it was a bug on SeaBIOS side, we need it to parse Alias term in AML
> instead of choking on it
> 
> proposed patch:
>  
> https://mail.coreboot.org/hyperkitty/list/seabios@seabios.org/thread/RGPL7HESH5U5JRLEO6FP77CZVHZK5J65/
> 
> PS:
> it's probably too late for it to make into 7.2

Right. So revert?