qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests/avocado: configure acpi-bits to use avocado timeout


From: Ani Sinha
Subject: Re: [PATCH] tests/avocado: configure acpi-bits to use avocado timeout
Date: Fri, 18 Nov 2022 21:48:56 +0530

On Fri, Nov 18, 2022 at 1:33 PM Thomas Huth <thuth@redhat.com> wrote:
>
> On 18/11/2022 05.05, Ani Sinha wrote:
> > On Wed, Nov 16, 2022 at 8:54 AM Ani Sinha <ani@anisinha.ca> wrote:
> >>
> >> On Wed, Nov 16, 2022 at 2:58 AM John Snow <jsnow@redhat.com> wrote:
> >>>
> >>> Instead of using a hardcoded timeout, just rely on Avocado's built-in
> >>> test case timeout. This helps avoid timeout issues on machines where 60
> >>> seconds is not sufficient.
> >>>
> >>> Signed-off-by: John Snow <jsnow@redhat.com>
> >>
> >> Reviewed-by: Ani Sinha <ani@anisinha.ca>
> >>
> >>> ---
> >>>   tests/avocado/acpi-bits.py | 10 ++--------
> >>>   1 file changed, 2 insertions(+), 8 deletions(-)
> >
> > Thomas, since you are picking up my other patch, maybe you want to
> > also pick this one up as well if you have not sent out your PR
> > already?
>
> Sorry, too late, it's already merged:
>
> https://gitlab.com/qemu-project/qemu/-/commit/1b7a07c4414323d985e89c4e7

Ok if you generate another PR with simple misc fixes, please let me know.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]