Re: [PATCH v4 0/7] Add ARM Cortex-R52 CPU

[Peter Maydell]

On Sun, 23 Oct 2022 at 16:37, <tobias.roehmel@rwth-aachen.de> wrote:
>
> From: Tobias Röhmel <quic_trohmel@quicinc.com>
>
> Thanks again for all the help!
>
> Here is v4:
> 2. Made patch cleaner
> 3. Changed commit message
> 4. Replaced V8_R flag with ARM_FEATURE_PMSA|ARM_FEATURE_V8
> 5.
> Reworked the code to use existing pmsav7 variables
> Added migration support
> Added VSCTLR:
> I didn't add any functionality for it because I think
> Qemu doesn't model the behaviour it influences.
> 6.
> Lots of cleanup. I think I overcomplicated this a bit because
> of a misunderstanding. I thought HCR_VM is independent of enabling
> the different MPUs, but I see now that it doesn't make sense to enable
> HCR_VM when the MPUs are not enabled. I also think that there is an Error
> in the armv8-r manual supplement in Figure C1-3. With all that figured out
> the code for pmsav8r doesn't look that different from pmsav7 :)

I've now reviewed this version of the patchset; it's getting
quite close now, I think. Sorry it took me so long to get back to it.

-- PMM