[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 07/13] docs/devel: try and improve the language around patch r
From: |
Alex Bennée |
Subject: |
[PATCH v3 07/13] docs/devel: try and improve the language around patch review |
Date: |
Thu, 17 Nov 2022 17:25:26 +0000 |
It is important that contributors take the review process seriously
and we collaborate in a respectful way while avoiding personal
attacks. Try and make this clear in the language.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20221111145529.4020801-9-alex.bennee@linaro.org>
---
docs/devel/submitting-a-patch.rst | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/docs/devel/submitting-a-patch.rst
b/docs/devel/submitting-a-patch.rst
index 1f2bde0625..80e8693bb6 100644
--- a/docs/devel/submitting-a-patch.rst
+++ b/docs/devel/submitting-a-patch.rst
@@ -434,14 +434,20 @@ developers will identify bugs, or suggest a cleaner
approach, or even
just point out code style issues or commit message typos. You'll need to
respond to these, and then send a second version of your patches with
the issues fixed. This takes a little time and effort on your part, but
-if you don't do it then your changes will never get into QEMU. It's also
-just polite -- it is quite disheartening for a developer to spend time
-reviewing your code and suggesting improvements, only to find that
-you're not going to do anything further and it was all wasted effort.
+if you don't do it then your changes will never get into QEMU.
+
+Remember that a maintainer is under no obligation to take your
+patches. If someone has spent the time reviewing your code and
+suggesting improvements and you simply re-post without either
+addressing the comment directly or providing additional justification
+for the change then it becomes wasted effort. You cannot demand others
+merge and then fix up your code after the fact.
When replying to comments on your patches **reply to all and not just
the sender** -- keeping discussion on the mailing list means everybody
-can follow it.
+can follow it. Remember the spirit of the :ref:`code_of_conduct` and
+keep discussions respectful and collaborative and avoid making
+personal comments.
.. _pay_attention_to_review_comments:
--
2.34.1
- [PATCH for 7.2 v3 00/13] testing and doc updates (pre-PR), Alex Bennée, 2022/11/17
- [PATCH v3 02/13] tests/avocado/machine_aspeed.py: Reduce noise on the console for SDK tests, Alex Bennée, 2022/11/17
- [PATCH v3 01/13] Run docker probe only if docker or podman are available, Alex Bennée, 2022/11/17
- [PATCH v3 05/13] docs/devel: make language a little less code centric, Alex Bennée, 2022/11/17
- [PATCH v3 04/13] docs/devel: add a maintainers section to development process, Alex Bennée, 2022/11/17
- [PATCH v3 09/13] tests/avocado: introduce alpine virt test for CI, Alex Bennée, 2022/11/17
- [PATCH v3 07/13] docs/devel: try and improve the language around patch review,
Alex Bennée <=
- [PATCH v3 06/13] docs/devel: simplify the minimal checklist, Alex Bennée, 2022/11/17
- [PATCH v3 08/13] tests/avocado: Raise timeout for boot_linux.py:BootLinuxPPC64.test_pseries_tcg, Alex Bennée, 2022/11/17
- [PATCH v3 03/13] tests/docker: allow user to override check target, Alex Bennée, 2022/11/17
- [PATCH v3 13/13] ci: replace x86_64 macos-11 with aarch64 macos-12, Alex Bennée, 2022/11/17
- [PATCH v3 10/13] tests/avocado: skip aarch64 cloud TCG tests in CI, Alex Bennée, 2022/11/17
- [PATCH v3 12/13] tests/avocado/boot_linux.py: Bump aarch64 virt test timeout to 720s, Alex Bennée, 2022/11/17