[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for 8.0 v7 01/10] vdpa: Use v->shadow_vqs_enabled in vhost_vd
From: |
Jason Wang |
Subject: |
Re: [PATCH for 8.0 v7 01/10] vdpa: Use v->shadow_vqs_enabled in vhost_vdpa_svqs_start & stop |
Date: |
Thu, 17 Nov 2022 13:43:11 +0800 |
On Wed, Nov 16, 2022 at 11:06 PM Eugenio Pérez <eperezma@redhat.com> wrote:
>
> This function used to trust in v->shadow_vqs != NULL to know if it must
> start svq or not.
>
> This is not going to be valid anymore, as qemu is going to allocate svq
> unconditionally (but it will only start them conditionally).
>
> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Thanks
> ---
> hw/virtio/vhost-vdpa.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
> index 7468e44b87..7f0ff4df5b 100644
> --- a/hw/virtio/vhost-vdpa.c
> +++ b/hw/virtio/vhost-vdpa.c
> @@ -1029,7 +1029,7 @@ static bool vhost_vdpa_svqs_start(struct vhost_dev *dev)
> Error *err = NULL;
> unsigned i;
>
> - if (!v->shadow_vqs) {
> + if (!v->shadow_vqs_enabled) {
> return true;
> }
>
> @@ -1082,7 +1082,7 @@ static void vhost_vdpa_svqs_stop(struct vhost_dev *dev)
> {
> struct vhost_vdpa *v = dev->opaque;
>
> - if (!v->shadow_vqs) {
> + if (!v->shadow_vqs_enabled) {
> return;
> }
>
> --
> 2.31.1
>
- [PATCH for 8.0 v7 00/10] ASID support in vhost-vdpa net, Eugenio Pérez, 2022/11/16
- [PATCH for 8.0 v7 02/10] vhost: set SVQ device call handler at SVQ start, Eugenio Pérez, 2022/11/16
- [PATCH for 8.0 v7 01/10] vdpa: Use v->shadow_vqs_enabled in vhost_vdpa_svqs_start & stop, Eugenio Pérez, 2022/11/16
- Re: [PATCH for 8.0 v7 01/10] vdpa: Use v->shadow_vqs_enabled in vhost_vdpa_svqs_start & stop,
Jason Wang <=
- [PATCH for 8.0 v7 03/10] vhost: Allocate SVQ device file descriptors at device start, Eugenio Pérez, 2022/11/16
- [PATCH for 8.0 v7 04/10] vdpa: add vhost_vdpa_net_valid_svq_features, Eugenio Pérez, 2022/11/16
- [PATCH for 8.0 v7 06/10] vdpa: Allocate SVQ unconditionally, Eugenio Pérez, 2022/11/16
- [PATCH for 8.0 v7 07/10] vdpa: Add asid parameter to vhost_vdpa_dma_map/unmap, Eugenio Pérez, 2022/11/16
- [PATCH for 8.0 v7 08/10] vdpa: Store x-svq parameter in VhostVDPAState, Eugenio Pérez, 2022/11/16
- [PATCH for 8.0 v7 09/10] vdpa: Add shadow_data to vhost_vdpa, Eugenio Pérez, 2022/11/16