[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] disas: recognize either <capstone.h> or <capstone/capston
From: |
Peter Maydell |
Subject: |
Re: [PATCH v2] disas: recognize either <capstone.h> or <capstone/capstone.h> |
Date: |
Tue, 15 Nov 2022 11:59:21 +0000 |
On Tue, 15 Nov 2022 at 11:55, Michael Tokarev <mjt@tls.msk.ru> wrote:
>
> Historically, capstone varies in requiring either <capstone.h>
> or <capstone/capstone.h> include depending on version and the
> way how it has been installed. This has already been an issue
> before, and will likely become an issue again with capstone
> 5.0 which seem to have changed this aspect once again.
>
> Recognize both ways in the meson check, but prefer <capstone.h>
> so it's easy to override which capstone to use by
> pkgconfig's --cflags (or --extra-cflags).
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> v2: use cc.has_header, not cc.compile (pm215)
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM