qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] capstone: use <capstone/capstone.h> instead of <capstone.


From: Michael Tokarev
Subject: Re: [PATCH v2] capstone: use <capstone/capstone.h> instead of <capstone.h>
Date: Tue, 15 Nov 2022 12:25:19 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0

14.11.2022 14:59, Peter Maydell wrote:
..
We can do something like

config_host_data.set('HAVE_CAPSTONE_CAPSTONE_H',
cc.has_header('capstone/capstone.h', depedencies: [capstone])

This doesn't work, because has_header does not have "dependencies"
argument.  And without that, it doesn't take pkgconfig's --cflags
into account.

Dan: is there a reason why in commit 8f4aea712ffc4 you wrote
the "check that capstone.h really exists" check with cc.compiles
rather than cc.has_header ?

Maybe that's why.

/mjt




reply via email to

[Prev in Thread] Current Thread [Next in Thread]