[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] Do not access /dev/mem in MSI-X PCI passthrough on Xen
From: |
Jan Beulich |
Subject: |
Re: [PATCH 2/2] Do not access /dev/mem in MSI-X PCI passthrough on Xen |
Date: |
Tue, 15 Nov 2022 09:14:07 +0100 |
User-agent: |
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 |
On 14.11.2022 20:20, Marek Marczykowski-Górecki wrote:
> The /dev/mem is used for two purposes:
> - reading PCI_MSIX_ENTRY_CTRL_MASKBIT
> - reading Pending Bit Array (PBA)
>
> The first one was originally done because when Xen did not send all
> vector ctrl writes to the device model, so QEMU might have outdated old
> register value. This has been changed in Xen, so QEMU can now use its
> cached value of the register instead.
>
> The Pending Bit Array (PBA) handling is for the case where it lives on
> the same page as the MSI-X table itself. Xen has been extended to handle
> this case too (as well as other registers that may live on those pages),
> so QEMU handling is not necessary anymore.
Don't you need to check for new enough Xen for both aspects?
Jan
Re: [PATCH 1/2] hw/xen/xen_pt: Call default handler only if no custom one is set, Anthony PERARD, 2022/11/22