Re: [PATCH v2 2/8] target/riscv: add support for Zca and Zcf extensions

[weiwei]

On 2022/11/14 05:40, Richard Henderson wrote:
> On 11/13/22 12:32, Weiwei Li wrote:
> > +        } else if ((get_xl_max(ctx) == MXL_RV32) &&
> > +            !ctx->cfg_ptr->ext_zcf &&
> > +            (((opcode & 0xe003) == 0x6000) ||
> > +             ((opcode & 0xe003) == 0x6002) ||
> > +             ((opcode & 0xe003) == 0xe000) ||
> > +             ((opcode & 0xe003) == 0xe002))) {
> >               gen_exception_illegal(ctx);
>
> Why aren't you using the same c_flw solution that you do for Zcd?
Yeah, it's OK for zcf intructions to use the c_flw solution.

I tried to remain the original logic for Zcf and Zcd instructions, 
However, this way is not suitable for Zcd instructions

since zcmp/zcmt instructions will overlap their encodings(but not the 
same).  So I changed the way of Zcd instructions.

Regards,

Weiwei Li

> r~