Re: [PATCH v7 10/12] multifd: Support for zero pages transmission

[Juan Quintela]

chuang xu <xuchuangxclwt@bytedance.com> wrote:
> On 2022/8/2 下午2:39, Juan Quintela wrote:
>> This patch adds counters and similar.  Logic will be added on the
>> following patch.
>>
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>>

>>           sync_needed = p->flags & MULTIFD_FLAG_SYNC;
>>           /* recv methods don't know how to handle the SYNC flag */
>>           p->flags &= ~MULTIFD_FLAG_SYNC;
>>           p->num_packets++;
>>           p->total_normal_pages += p->normal_num;
>> +        p->total_normal_pages += p->zero_num;
>
> Hi, Juan:
>
> If I understand correctly, it should be "p->total_zero_pages +=
> p->zero_num; ".

Very good catch. Thanks.

That is what rebases make to you.

> By the way, This patch seems to greatly improve the performance of
> zero page checking,  but it seems that there has been no new update in
> the past two months. I want to know when it will be merged into
> master?

I am resending right now.

Later, Juan.