[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 3/8] qemu-img: remove unused variable
From: |
Thomas Huth |
Subject: |
[PULL 3/8] qemu-img: remove unused variable |
Date: |
Fri, 11 Nov 2022 11:30:43 +0100 |
From: Miroslav Rezanina <mrezanin@redhat.com>
Variable block_count used in img_dd function is only incremented but never read.
This causes 'Unused but set variable' warning on Clang 15.0.1 compiler.
Removing the variable to prevent the warning.
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id:
<e86d5b57f9d13bde995c616a533b876f1fb8a527.1668009030.git.mrezanin@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
qemu-img.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index a3b64c88af..a9b3a8103c 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -4922,7 +4922,7 @@ static int img_dd(int argc, char **argv)
const char *out_fmt = "raw";
const char *fmt = NULL;
int64_t size = 0;
- int64_t block_count = 0, out_pos, in_pos;
+ int64_t out_pos, in_pos;
bool force_share = false;
struct DdInfo dd = {
.flags = 0,
@@ -5122,7 +5122,7 @@ static int img_dd(int argc, char **argv)
in.buf = g_new(uint8_t, in.bsz);
- for (out_pos = 0; in_pos < size; block_count++) {
+ for (out_pos = 0; in_pos < size; ) {
int bytes = (in_pos + in.bsz > size) ? size - in_pos : in.bsz;
ret = blk_pread(blk1, in_pos, bytes, in.buf, 0);
--
2.31.1
- [PULL 0/8] Misc fixes, Thomas Huth, 2022/11/11
- [PULL 1/8] rtl8139: Remove unused variable, Thomas Huth, 2022/11/11
- [PULL 2/8] tulip: Remove unused variable, Thomas Huth, 2022/11/11
- [PULL 3/8] qemu-img: remove unused variable,
Thomas Huth <=
- [PULL 4/8] host-libusb: Remove unused variable, Thomas Huth, 2022/11/11
- [PULL 5/8] libdecnumber/dpd/decimal64: Fix compiler warning from Clang 15, Thomas Huth, 2022/11/11
- [PULL 7/8] net: Replace TAB indentations with spaces, Thomas Huth, 2022/11/11
- [PULL 8/8] Fix several typos in documentation (found by codespell), Thomas Huth, 2022/11/11
- [PULL 6/8] qga: Allow building of the guest agent without system emulators or tools, Thomas Huth, 2022/11/11
- Re: [PULL 0/8] Misc fixes, Stefan Hajnoczi, 2022/11/12