Re: [PATCH v2 04/19] osdep.h: Introduce a QEMU file descriptor type

[Bin Meng]

Hi Daniel,

On Fri, Nov 11, 2022 at 5:08 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Fri, Nov 11, 2022 at 12:22:10PM +0800, Bin Meng wrote:
> > Introduce a new QemuFd_t type to represent a file descriptor for
> > different platforms. On POSIX platforms, this is a file descriptor
> > On Windows, this is a file handle.
>
> Can we not use  _open_osfhandle() to obtain a C runtime
> file descriptor from the Windows HANDLE.  We do this in
> QEMU's socket code, so we don't have to work wit different
> types and APIs on Windows, and I think that's much nicer
> in general.
>

I am sorry I don't understand your suggestion. I checked
qemu-sockets.c and did not see how sockets connect to this change.

This change is required to make 9pfs Windows support much easier.

Regards,
Bin