[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH for-8.0 v2 08/13] target/s390x: Use Int128 for return from TRE
From: |
Richard Henderson |
Subject: |
[PATCH for-8.0 v2 08/13] target/s390x: Use Int128 for return from TRE |
Date: |
Fri, 11 Nov 2022 18:08:15 +1000 |
Acked-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/s390x/helper.h | 2 +-
target/s390x/tcg/mem_helper.c | 7 +++----
target/s390x/tcg/translate.c | 7 +++++--
3 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/target/s390x/helper.h b/target/s390x/helper.h
index 16045b6dbe..aaea177246 100644
--- a/target/s390x/helper.h
+++ b/target/s390x/helper.h
@@ -99,7 +99,7 @@ DEF_HELPER_FLAGS_4(unpka, TCG_CALL_NO_WG, i32, env, i64, i32,
i64)
DEF_HELPER_FLAGS_4(unpku, TCG_CALL_NO_WG, i32, env, i64, i32, i64)
DEF_HELPER_FLAGS_3(tp, TCG_CALL_NO_WG, i32, env, i64, i32)
DEF_HELPER_FLAGS_4(tr, TCG_CALL_NO_WG, void, env, i32, i64, i64)
-DEF_HELPER_4(tre, i64, env, i64, i64, i64)
+DEF_HELPER_4(tre, i128, env, i64, i64, i64)
DEF_HELPER_4(trt, i32, env, i32, i64, i64)
DEF_HELPER_4(trtr, i32, env, i32, i64, i64)
DEF_HELPER_5(trXX, i32, env, i32, i32, i32, i32)
diff --git a/target/s390x/tcg/mem_helper.c b/target/s390x/tcg/mem_helper.c
index bb6714aee4..caf8c408ef 100644
--- a/target/s390x/tcg/mem_helper.c
+++ b/target/s390x/tcg/mem_helper.c
@@ -1632,8 +1632,8 @@ void HELPER(tr)(CPUS390XState *env, uint32_t len,
uint64_t array,
do_helper_tr(env, len, array, trans, GETPC());
}
-uint64_t HELPER(tre)(CPUS390XState *env, uint64_t array,
- uint64_t len, uint64_t trans)
+Int128 HELPER(tre)(CPUS390XState *env, uint64_t array,
+ uint64_t len, uint64_t trans)
{
uintptr_t ra = GETPC();
uint8_t end = env->regs[0] & 0xff;
@@ -1668,8 +1668,7 @@ uint64_t HELPER(tre)(CPUS390XState *env, uint64_t array,
}
env->cc_op = cc;
- env->retxl = len - i;
- return array + i;
+ return int128_make128(len - i, array + i);
}
static inline uint32_t do_helper_trt(CPUS390XState *env, int len,
diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c
index 112ec35160..4ad951a46f 100644
--- a/target/s390x/tcg/translate.c
+++ b/target/s390x/tcg/translate.c
@@ -4903,8 +4903,11 @@ static DisasJumpType op_tr(DisasContext *s, DisasOps *o)
static DisasJumpType op_tre(DisasContext *s, DisasOps *o)
{
- gen_helper_tre(o->out, cpu_env, o->out, o->out2, o->in2);
- return_low128(o->out2);
+ TCGv_i128 pair = tcg_temp_new_i128();
+
+ gen_helper_tre(pair, cpu_env, o->out, o->out2, o->in2);
+ tcg_gen_extr_i128_i64(o->out2, o->out, pair);
+ tcg_temp_free_i128(pair);
set_cc_static(s);
return DISAS_NEXT;
}
--
2.34.1
- [PATCH for-8.0 v2 00/13] target/s390x: Use TCGv_i128, Richard Henderson, 2022/11/11
- [PATCH for-8.0 v2 01/13] tests/tcg/s390x: Add div.c, Richard Henderson, 2022/11/11
- [PATCH for-8.0 v2 02/13] tests/tcg/s390x: Add clst.c, Richard Henderson, 2022/11/11
- [PATCH for-8.0 v2 03/13] tests/tcg/s390x: Add long-double.c, Richard Henderson, 2022/11/11
- [PATCH for-8.0 v2 05/13] target/s390x: Use a single return for helper_divs64/u64, Richard Henderson, 2022/11/11
- [PATCH for-8.0 v2 04/13] target/s390x: Use a single return for helper_divs32/u32, Richard Henderson, 2022/11/11
- [PATCH for-8.0 v2 08/13] target/s390x: Use Int128 for return from TRE,
Richard Henderson <=
- [PATCH for-8.0 v2 06/13] target/s390x: Use Int128 for return from CLST, Richard Henderson, 2022/11/11
- [PATCH for-8.0 v2 07/13] target/s390x: Use Int128 for return from CKSM, Richard Henderson, 2022/11/11
- [PATCH for-8.0 v2 09/13] target/s390x: Copy wout_x1 to wout_x1_P, Richard Henderson, 2022/11/11
- [PATCH for-8.0 v2 13/13] target/s390x: Implement CC_OP_NZ in gen_op_calc_cc, Richard Henderson, 2022/11/11
- [PATCH for-8.0 v2 10/13] target/s390x: Use Int128 for returning float128, Richard Henderson, 2022/11/11
- [PATCH for-8.0 v2 11/13] target/s390x: Use Int128 for passing float128, Richard Henderson, 2022/11/11
- [PATCH for-8.0 v2 12/13] target/s390x: Use tcg_gen_atomic_cmpxchg_i128 for CDSG, Richard Henderson, 2022/11/11