Re: [PATCH v2 13/18] tests: add migration tests of TLS with x509 credentials

[Thomas Huth]

On 10/03/2022 18.18, Daniel P. Berrangé wrote:
> This validates that we correctly handle migration success and failure
> scenarios when using TLS with x509 certificates. There are quite a few
> different scenarios that matter in relation to hostname validation.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
[...]
> +static void
> +test_migrate_tls_x509_finish(QTestState *from,
> +                             QTestState *to,
> +                             void *opaque)
> +{
> +    TestMigrateTLSX509Data *data = opaque;
> +
> +    test_tls_cleanup(data->keyfile);
> +    unlink(data->cacert);
> +    unlink(data->servercert);
> +    unlink(data->serverkey);
> +    unlink(data->clientcert);
> +    unlink(data->clientkey);
> +    rmdir(data->workdir);
> +
> +    g_free(data->workdir);
> +    g_free(data->keyfile);
> +    g_free(data);
> +}

 Hi Daniel!

FYI, this seems to create a test failure with Clang 15 from Fedora 37:

https://gitlab.com/thuth/qemu/-/jobs/3304199277#L3761

Looks like data->clientcert has to be checked for NULL before unlink is 
called with it?

 Thomas