[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add missing pixman dependecy
|
From: |
Miroslav Rezanina |
|
Subject: |
Re: [PATCH] Add missing pixman dependecy |
|
Date: |
Fri, 11 Nov 2022 07:42:45 +0100 |
On Wed, Nov 9, 2022 at 5:14 PM Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Hi Mirek,
>
> On 9/11/22 16:34, mrezanin@redhat.com wrote:
> > From: Miroslav Rezanina <mrezanin@redhat.com>
> >
> > Commit cfead31326 'acpi: pc: vga: use AcpiDevAmlIf interface to build VGA
> > device descriptors' added
> > a new file - acpi-vga.c. This file (indirectly) includes pixman.h file so
> > we need to ensure pixman
> > is available when file is compiled.
>
> We don't need this dependency if we move the build_vga_aml() declaration
> out of hw/display/vga_int.h, i.e. hw/display/acpi-vga.h.
>
I'm not confident enough to change header files, especially during RC
phase. I followed the pattern used in the hw/display/meson.build as we
need this to be fixed before GA.
Mirek
> Regards,
>
> Phil.
>
--
Miroslav Řezanina
Virtualization Team - Maintainer