Re: [PATCH v2 1/2] hw/nvme: fix incorrect use of errp/local_err

[Klaus Jensen]

On Nov 10 10:59, Philippe Mathieu-Daudé wrote:
> On 10/11/22 07:23, Klaus Jensen wrote:
> > From: Klaus Jensen <k.jensen@samsung.com>
> > 
> > Make nvme_check_constraints() return a bool and fix an invalid error
> > propagation where the actual error is thrown away in favor of an unused
> > local Error value.
> > 
> > Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> > ---
> >   hw/nvme/ctrl.c | 48 +++++++++++++++++++++++-------------------------
> >   1 file changed, 23 insertions(+), 25 deletions(-)
> 
> > @@ -7586,7 +7585,6 @@ static void nvme_realize(PCIDevice *pci_dev, Error 
> > **errp)
> >                 &pci_dev->qdev, n->parent_obj.qdev.id);
> >       if (nvme_init_subsys(n, errp)) {
> 
> Similarly nvme_init_subsys() could return a boolean.
> 

Yes, Markus pointed that out as well. A lot of functions would benefit
from similar changes, but I'd rather defer that until after 7.2 ;)

signature.asc
Description: PGP signature