Re: [PATCH v4 0/6] Only generate cluster node in PPTT when specified

[Peter Maydell]

On Wed, 2 Nov 2022 at 08:17, Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Tue, Nov 01, 2022 at 03:10:42PM +0800, Yicong Yang wrote:
> > From: Yicong Yang <yangyicong@hisilicon.com>
> >
> > This series mainly change the policy for building a cluster topology node
> > in PPTT. Previously we'll always build a cluster node in PPTT without
> > asking the user, after this set the cluster node will be built only the
> > the user specify through "-smp clusters=X".
> >
> > One problem is related to this but not fully caused by this, see the
> > discussion in [*]. When booting the VM with `-smp 8` and 4 numa nodes,
> > the linux scheduling domains in the VM misses the NUMA domains. It's
> > because the MC level span extends to Cluster level (which is generated
> > by the Qemu by default) that spans all the cpus in the system, then the
> > scheduling domain building stops at MC level since it already includes all
> > the cpus.
> >
> > Considering cluster is an optional level and most platforms don't have it,
> > they may even don't realize this is built and a always build policy cannot
> > emulate the real topology on these platforms. So in this series improve the
> > policy to only generate cluster when the user explicitly want it.
> >
> > Update the tests and test tables accordingly.
>
> I think we can classify this as a bugfix and so allow after
> the freeze, however, this needs ack from ARM maintainers then.

I don't use, test or understand any of the ACPI related code :-)
I'm happy to leave it up to your judgement whether this should go
into this release or wait for 8.0.

thanks
-- PMM