qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-8.0 0/2] hw/input/ps2: Convert to 3-phase reset


From: Mark Cave-Ayland
Subject: Re: [PATCH for-8.0 0/2] hw/input/ps2: Convert to 3-phase reset
Date: Thu, 10 Nov 2022 11:57:31 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0

On 10/11/2022 11:22, Peter Maydell wrote:

On Thu, 10 Nov 2022 at 10:36, Mark Cave-Ayland
<mark.cave-ayland@ilande.co.uk> wrote:
I haven't used the new ResettableClass myself previously, however it seems to 
match
the excellent documentation at 
https://qemu.readthedocs.io/en/latest/devel/reset.html
so feel free to add my Acked-by tag.

One part that did stand out to me in the docs is the part that reads "For now
migration of a device or bus in reset is not supported. Care must be taken not 
to
delay resettable_release_reset() after its resettable_assert_reset() 
counterpart". Is
this still a valid concern and something we need to think about? I'm thinking 
about
if a guest triggers a SCSI bus or PCI bus reset for example.

That only matters if there's a way for the guest to hold the device
in reset, as opposed to resetting it as a point event. This is
theoretically possible to do with the new API, and was simply
impossible with the old API because with the old one reset was
always a one-shot point event.

I see, thanks. And the documentation confirms that resettable_reset() is an assert immediately followed by a release so that shouldn't be an issue for device_cold_reset() and bus_cold_reset() calling the new Resettable inteface.


ATB,

Mark.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]