Re: [PATCH] Use a more portable way to enable target specific functions

[Daniel P . Berrangé]

On Thu, Nov 10, 2022 at 02:43:28PM +1100, Richard Henderson wrote:
> On 11/10/22 09:03, Tom Stellard wrote:
> > This adds function attributes for avx2, sse2, etc. specialized
> > functions.  These attributes are supported by both clang and gcc and
> > are necessary in order to build the code with clang.  The existing gcc
> > specific pragmas were left in place due to a comment in
> > utils/bufferiszero.c which mentions the pragmas are needed before headers
> > to work around a bug in gcc <= 4.8.
> 
> GCC 4.8 is now below our minimum, surely.
> We should be able to simply replace the pragma with the attribute.

We mandate at least GCC v7.4 or Clang v6.0 (or XCode Clang v10.0)

> 
> 
> r~
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|