qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 10/13] block: Call drain callbacks only once


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH 10/13] block: Call drain callbacks only once
Date: Wed, 9 Nov 2022 21:54:41 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2

On 11/8/22 15:37, Kevin Wolf wrote:
One thing that gets in the way is the 'ignore_bds_parents' parameter in
bdrv_do_drained_begin_quiesce() and bdrv_do_drained_end(): If it is true
for the first drain, bs->quiesce_counter will be non-zero, but the
parent callbacks still haven't been called, so a second drain where it
is false would still have to call them.

This paragraph breaks my brain :/

Still, I understand the new concept and believe that dropping ignore_bds_parents 
and just call the callbacks once (and stop the recursion when we found 
quiesce_counter > 0) is a good way.

--
Best regards,
Vladimir




reply via email to

[Prev in Thread] Current Thread [Next in Thread]