Re: [PATCH] Revert "hw/block/pflash_cfi0{1, 2}: Error out if device length isn't a power of two"

[Daniel Henrique Barboza]

On 11/8/22 15:13, Stefan Hajnoczi wrote:
> On Tue, 8 Nov 2022 at 13:10, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
> > On 8/11/22 18:26, Daniel Henrique Barboza wrote:
> > > This commit caused a regression [1] that prevents machines that uses
> > > Open Virtual Machine Firmware (OVMF) to boot.
> > >
> > > This is a long standing behavior with how pflash handles images. More
> > > information about why this happens can be found in [2] and commit
> > > 06f1521795 ("pflash: Require backend size to match device, improve
> > > errors").
> > >
> > > This reverts commit 334c388f25707a234c4a0dea05b9df08d7746638.
> > >
> > > [1] https://gitlab.com/qemu-project/qemu/-/issues/1294
> > > [2] https://lore.kernel.org/qemu-devel/20190308062455.29755-1-armbru@redhat.com/
> > >
> > > Cc: Bernhard Beschow <shentey@gmail.com>
> > > Cc: Philippe Mathieu-Daudé <philmd@linaro.org>
> > > Cc: Stefan Hajnoczi <stefanha@gmail.com>
> > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1294
> > > Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
> > > ---
> > >    hw/block/pflash_cfi01.c | 8 ++------
> > >    hw/block/pflash_cfi02.c | 5 -----
> > >    2 files changed, 2 insertions(+), 11 deletions(-)
> >
> > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> >
> > Thanks, our patches crossed :)
> > 20221108175755.95141-1-philmd@linaro.org/">https://lore.kernel.org/qemu-devel/20221108175755.95141-1-philmd@linaro.org/

Well of course that we both decided to send the PR almost at the same time :D

> > I'm queuing yours which is first and will amend the description
> > (if you don't disagree).
>
> I've already applied yours, Philippe, because the description is more
> comprehensive.
>
> Daniel, thank you for sending your version of the patch!

Thank you Phil for sending the revert and Stefan for quickly queueing
it. The sooner we get rid of the regression the better.


Daniel



> Stefan