[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v1 4/9] tests/docker: allow user to override check target
From: |
Alex Bennée |
Subject: |
[PATCH v1 4/9] tests/docker: allow user to override check target |
Date: |
Tue, 8 Nov 2022 09:23:03 +0000 |
This is useful when trying to bisect a particular failing test behind
a docker run. For example:
make docker-test-clang@fedora \
TARGET_LIST=arm-softmmu \
TEST_COMMAND="meson test qtest-arm/qos-test" \
J=9 V=1
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
v1
- fix s/target /target./
- CHECK_TARGET -> TEST_COMMAND
---
tests/docker/Makefile.include | 2 ++
tests/docker/common.rc | 6 +++---
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index c87f14477a..fc7a3b7e71 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -184,6 +184,7 @@ docker:
@echo ' TARGET_LIST=a,b,c Override target list in builds.'
@echo ' EXTRA_CONFIGURE_OPTS="..."'
@echo ' Extra configure options.'
+ @echo ' TEST_COMMAND="..." Override the default `make check`
target.'
@echo ' IMAGES="a b c ..": Restrict available images to subset.'
@echo ' TESTS="x y z .." Restrict available tests to subset.'
@echo ' J=[0..9]* Overrides the -jN parameter for make
commands'
@@ -230,6 +231,7 @@ docker-run: docker-qemu-src
$(if $(NETWORK),$(if $(subst
$(NETWORK),,1),--net=$(NETWORK)),--net=none) \
-e TARGET_LIST=$(subst
$(SPACE),$(COMMA),$(TARGET_LIST)) \
-e EXTRA_CONFIGURE_OPTS="$(EXTRA_CONFIGURE_OPTS)" \
+ -e TEST_COMMAND="$(TEST_COMMAND)" \
-e V=$V -e J=$J -e DEBUG=$(DEBUG) \
-e SHOW_ENV=$(SHOW_ENV) \
$(if $(NOUSER),, \
diff --git a/tests/docker/common.rc b/tests/docker/common.rc
index e6f8cee0d6..9a33df2832 100755
--- a/tests/docker/common.rc
+++ b/tests/docker/common.rc
@@ -63,12 +63,12 @@ check_qemu()
{
# default to make check unless the caller specifies
if [ $# = 0 ]; then
- INVOCATION="check"
+ INVOCATION="${TEST_COMMAND:-make $MAKEFLAGS check}"
else
- INVOCATION="$@"
+ INVOCATION="make $MAKEFLAGS $@"
fi
- make $MAKEFLAGS $INVOCATION
+ $INVOCATION
}
test_fail()
--
2.34.1
- [PATCH v1 for 7.2 0/9] test and doc updates, Alex Bennée, 2022/11/08
- [PATCH v1 1/9] Run docker probe only if docker or podman are available, Alex Bennée, 2022/11/08
- [PATCH v1 2/9] tests/avocado: improve behaviour waiting for login prompts, Alex Bennée, 2022/11/08
- [PATCH v1 6/9] docs/devel: add a maintainers section to development process, Alex Bennée, 2022/11/08
- [PATCH v1 4/9] tests/docker: allow user to override check target,
Alex Bennée <=
- [PATCH v1 7/9] docs/devel: make language a little less code centric, Alex Bennée, 2022/11/08
- [PATCH v1 5/9] hw/virtio: introduce virtio_device_should_start, Alex Bennée, 2022/11/08
- Re: [PATCH v1 5/9] hw/virtio: introduce virtio_device_should_start, Michael S. Tsirkin, 2022/11/08
- Re: [PATCH v1 5/9] hw/virtio: introduce virtio_device_should_start, Alex Bennée, 2022/11/08
- Re: [PATCH v1 5/9] hw/virtio: introduce virtio_device_should_start, Michael S. Tsirkin, 2022/11/08
- Re: [PATCH v1 5/9] hw/virtio: introduce virtio_device_should_start, Alex Bennée, 2022/11/08
- Re: [PATCH v1 5/9] hw/virtio: introduce virtio_device_should_start, Michael S. Tsirkin, 2022/11/08
- Re: [PATCH v1 5/9] hw/virtio: introduce virtio_device_should_start, Alex Bennée, 2022/11/08
Re: [PATCH v1 5/9] hw/virtio: introduce virtio_device_should_start, Michael S. Tsirkin, 2022/11/08