|
From: | Thomas Huth |
Subject: | Re: [PATCH 2/3] net: Restore printing of the help text with "-nic help" |
Date: | Tue, 8 Nov 2022 09:59:48 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 |
On 08/11/2022 09.52, Claudio Fontana wrote:
On 11/8/22 09:42, Thomas Huth wrote:On 07/11/2022 13.27, Claudio Fontana wrote:should -net and -netdev be adapted too?"-netdev help" already works just fine ... and "-net" should IMHO rather be removed than improved ;-) ThomasI wonder if it could be done once for all, in net_init_clients, instead of repeating the is_help_option in net_init_netdev and net_param_nic (and that would take care of net_init_client too, so we'd get "net" for free)..
I don't think that it makes too much sense to have one option for all - since all three CLI options are slightly different anyway. E.g. "-net nic" only exists for "-net", "hubport" cannot be used with "-net", "-nic" can also be used to configure the NIC model, etc.
Thomas
[Prev in Thread] | Current Thread | [Next in Thread] |