Re: [PULL v3 00/81] pci,pc,virtio: features, tests, fixes, cleanups

[Michael S. Tsirkin]

On Mon, Nov 07, 2022 at 05:43:44AM -0500, Stefan Hajnoczi wrote:
> Hi Michael and Igor,
> Looks like the ACPI commits broken the virtio-vga module:
> 
> >>> QTEST_QEMU_IMG=./qemu-img MALLOC_PERTURB_=60 
> >>> G_TEST_DBUS_DAEMON=/builds/qemu-project/qemu/tests/dbus-vmstate-daemon.sh 
> >>> QTEST_QEMU_BINARY=./qemu-system-or1k 
> >>> QTEST_QEMU_STORAGE_DAEMON_BINARY=./storage-daemon/qemu-storage-daemon 
> >>> /builds/qemu-project/qemu/build/tests/qtest/device-introspect-test --tap 
> >>> -k
> ――――――――――――――――――――――――――――――――――――― ✀ ―――――――――――――――――――――――――――――――――――――
> stderr:
> failed to open module:
> /builds/qemu-project/qemu/build/qemu-bundle/usr/local/lib64/qemu/hw-display-virtio-vga.so:
> undefined symbol: aml_return
> qemu-system-or1k: ../util/error.c:59: error_setv: Assertion `*errp ==
> NULL' failed.
> Broken pipe
> ../tests/qtest/libqtest.c:188: kill_qemu() detected QEMU death from
> signal 6 (Aborted) (core dumped)
> TAP parsing error: Too few tests run (expected 6, got 0)
> (test program exited with status code -6)
> ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
> 154/274 qemu:qtest+qtest-or1k / qtest-or1k/machine-none-test OK 0.05s
> 1 subtests passed
> 155/274 qemu:qtest+qtest-or1k / qtest-or1k/qmp-test OK 0.19s 4 subtests passed
> 156/274 qemu:qtest+qtest-or1k / qtest-or1k/qmp-cmd-test ERROR 1.72s
> killed by signal 6 SIGABRT
> >>> QTEST_QEMU_IMG=./qemu-img 
> >>> G_TEST_DBUS_DAEMON=/builds/qemu-project/qemu/tests/dbus-vmstate-daemon.sh 
> >>> QTEST_QEMU_BINARY=./qemu-system-or1k 
> >>> QTEST_QEMU_STORAGE_DAEMON_BINARY=./storage-daemon/qemu-storage-daemon 
> >>> MALLOC_PERTURB_=53 
> >>> /builds/qemu-project/qemu/build/tests/qtest/qmp-cmd-test --tap -k
> ――――――――――――――――――――――――――――――――――――― ✀ ―――――――――――――――――――――――――――――――――――――
> stderr:
> failed to open module:
> /builds/qemu-project/qemu/build/qemu-bundle/usr/local/lib64/qemu/hw-display-virtio-vga.so:
> undefined symbol: aml_return
> qemu-system-or1k: ../util/error.c:59: error_setv: Assertion `*errp ==
> NULL' failed.
> Broken pipe
> ../tests/qtest/libqtest.c:188: kill_qemu() detected QEMU death from
> signal 6 (Aborted) (core dumped)
> TAP parsing error: Too few tests run (expected 62, got 31)
> (test program exited with status code -6)
> ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
> 
> https://gitlab.com/qemu-project/qemu/-/jobs/3281425457
> 
> Stefan


Hmm it passed for me:

https://gitlab.com/mstredhat/qemu/-/jobs/3279401710

Igor you did make a change around VGA:

commit 03d525c27ab0b268cf375d8823f05e91509222b8
Author: Igor Mammedov <imammedo@redhat.com>
Date:   Mon Oct 17 12:21:36 2022 +0200

    acpi: pc: vga: use AcpiDevAmlIf interface to build VGA device descriptors
    
    Signed-off-by: Igor Mammedov <imammedo@redhat.com>
    Message-Id: <20221017102146.2254096-2-imammedo@redhat.com>
    Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
    Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    NB: we do not expect any functional change in
    any ACPI tables with this change. It's only a refactoring.
    
    Reviewed-by: Ani Sinha <ani@anisinha.ca>


can you take a look pls?
How bad is it if I drop that patch?


-- 
MST
How is ths different