Re: [PATCH] tests/qtest/libqos/e1000e: Use e1000_regs.h

[Jason Wang]

On Tue, Oct 25, 2022 at 10:54 PM Thomas Huth <thuth@redhat.com> wrote:
>
> On 13/10/2022 07.52, Akihiko Odaki wrote:
> > The register definitions in tests/qtest/libqos/e1000e.c had names
> > different from hw/net/e1000_regs.h, which made it hard to understand
> > what test codes corresponds to the implementation. Use
> > hw/net/e1000_regs.h from tests/qtest/libqos/e1000e.c to remove
> > these duplications.
> >
> > E1000E_CTRL_EXT_TXLSFLOW is removed from E1000E_CTRL_EXT settings
> > because hw/net/e1000_regs.h does not have the definition and it is for
> > TCP segmentation offload, which does not matter for the implemented
> > tests.
> >
> > Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> > ---
> >   hw/net/e1000_regs.h         |   1 +
> >   tests/qtest/libqos/e1000e.c | 119 +++++++++++++-----------------------
> >   2 files changed, 45 insertions(+), 75 deletions(-)
>
> Acked-by: Thomas Huth <thuth@redhat.com>
>
> I can take it through my testing-next tree:

Acked-by: Jason Wang <jasowang@redhat.com>

>
>   https://gitlab.com/thuth/qemu/-/commits/testing-next
>
>   Thomas
>