[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 4/6] disas/nanomips: Tidy read for 48-bit opcodes
From: |
Richard Henderson |
Subject: |
[PATCH v2 4/6] disas/nanomips: Tidy read for 48-bit opcodes |
Date: |
Mon, 7 Nov 2022 08:28:50 +1100 |
There is no point in looking for a 48-bit opcode if we've
not read the second word for a 32-bit opcode.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
disas/nanomips.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/disas/nanomips.c b/disas/nanomips.c
index 717fafb739..abc78ae165 100644
--- a/disas/nanomips.c
+++ b/disas/nanomips.c
@@ -21962,14 +21962,14 @@ int print_insn_nanomips(bfd_vma memaddr, struct
disassemble_info *info)
return -1;
}
length = 4;
- }
- /* Handle 48-bit opcodes. */
- if ((words[0] >> 10) == 0x18) {
- if (!read_u16(&words[1], memaddr + 4, info)) {
- return -1;
+ /* Handle 48-bit opcodes. */
+ if ((words[0] >> 10) == 0x18) {
+ if (!read_u16(&words[1], memaddr + 4, info)) {
+ return -1;
+ }
+ length = 6;
}
- length = 6;
}
for (int i = 0; i < ARRAY_SIZE(words); i++) {
--
2.34.1
- [PATCH v2 0/6] Two -Wclobbered fixes, plus other cleanup, Richard Henderson, 2022/11/06
- [PATCH v2 1/6] disas/nanomips: Move setjmp into nanomips_dis, Richard Henderson, 2022/11/06
- [PATCH v2 2/6] disas/nanomips: Merge insn{1,2,3} into words[3], Richard Henderson, 2022/11/06
- [PATCH v2 3/6] disas/nanomips: Split out read_u16, Richard Henderson, 2022/11/06
- [PATCH v2 4/6] disas/nanomips: Tidy read for 48-bit opcodes,
Richard Henderson <=
- [PATCH v2 5/6] tcg: Move TCG_TARGET_HAS_direct_jump init to tb_gen_code, Richard Henderson, 2022/11/06
- [PATCH v2 6/6] accel/tcg: Split out setjmp_gen_code, Richard Henderson, 2022/11/06
- Re: [PATCH v2 0/6] Two -Wclobbered fixes, plus other cleanup, Philippe Mathieu-Daudé, 2022/11/07