[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/12] tests/qtest/libqos/e1000e: Use E1000_STATUS_ASDV_1000
From: |
Thomas Huth |
Subject: |
[PULL 04/12] tests/qtest/libqos/e1000e: Use E1000_STATUS_ASDV_1000 |
Date: |
Sun, 6 Nov 2022 16:31:48 +0100 |
From: Akihiko Odaki <akihiko.odaki@daynix.com>
Nemonics E1000_STATUS_LAN_INIT_DONE and E1000_STATUS_ASDV_1000 have
the same value, and E1000_STATUS_ASDV_1000 should be used here because
E1000_STATUS_ASDV_1000 represents the auto-detected speed tested here
while E1000_STATUS_LAN_INIT_DONE is a value used for a different purpose
with a variant of e1000e family different from the one implemented in
QEMU.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Message-Id: <20221103083425.100590-1-akihiko.odaki@daynix.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/libqos/e1000e.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qtest/libqos/e1000e.c b/tests/qtest/libqos/e1000e.c
index 4fd0bd5311..05af6f2118 100644
--- a/tests/qtest/libqos/e1000e.c
+++ b/tests/qtest/libqos/e1000e.c
@@ -130,8 +130,8 @@ static void e1000e_pci_start_hw(QOSGraphObject *obj)
/* Check the device status - link and speed */
val = e1000e_macreg_read(&d->e1000e, E1000_STATUS);
- g_assert_cmphex(val & (E1000_STATUS_LU | E1000_STATUS_LAN_INIT_DONE),
- ==, E1000_STATUS_LU | E1000_STATUS_LAN_INIT_DONE);
+ g_assert_cmphex(val & (E1000_STATUS_LU | E1000_STATUS_ASDV_1000),
+ ==, E1000_STATUS_LU | E1000_STATUS_ASDV_1000);
/* Initialize TX/RX logic */
e1000e_macreg_write(&d->e1000e, E1000_RCTL, 0);
--
2.31.1
- [PULL 00/12] qtest and s390x patches, Thomas Huth, 2022/11/06
- [PULL 01/12] tests/qtest/libqos/e1000e: Refer common PCI ID definitions, Thomas Huth, 2022/11/06
- [PULL 02/12] tests/qtest/libqos/e1000e: Set E1000_CTRL_SLU, Thomas Huth, 2022/11/06
- [PULL 05/12] tests/qtest/libqos/e1000e: Use IVAR shift definitions, Thomas Huth, 2022/11/06
- [PULL 03/12] tests/qtest/e1000e-test: Use e1000_regs.h, Thomas Huth, 2022/11/06
- [PULL 04/12] tests/qtest/libqos/e1000e: Use E1000_STATUS_ASDV_1000,
Thomas Huth <=
- [PULL 06/12] tests/qtest: Fix two format strings, Thomas Huth, 2022/11/06
- [PULL 08/12] gitlab-ci: increase clang-user timeout, Thomas Huth, 2022/11/06
- [PULL 07/12] tests/qtest: migration-test: Enable TLS PSK tests for win32, Thomas Huth, 2022/11/06
- [PULL 09/12] s390x/css: revert SCSW ctrl/flag bits on error, Thomas Huth, 2022/11/06
- [PULL 10/12] s390x/pci: RPCIT second pass when mappings exhausted, Thomas Huth, 2022/11/06
- [PULL 11/12] s390x: Register TYPE_S390_CCW_MACHINE properties as class properties, Thomas Huth, 2022/11/06
- [PULL 12/12] s390x/cpu topology: add max_threads machine class attribute, Thomas Huth, 2022/11/06
- Re: [PULL 00/12] qtest and s390x patches, Stefan Hajnoczi, 2022/11/07