qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 20/30] qapi qdev qom: Elide redundant has_FOO in generated


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v3 20/30] qapi qdev qom: Elide redundant has_FOO in generated C
Date: Sat, 5 Nov 2022 18:06:51 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1

On 4/11/22 17:07, Markus Armbruster wrote:
The has_FOO for pointer-valued FOO are redundant, except for arrays.
They are also a nuisance to work with.  Recent commit "qapi: Start to
elide redundant has_FOO in generated C" provided the means to elide
them step by step.  This is the step for qapi/qdev.json and
qapi/qom.json.

Said commit explains the transformation in more detail.  The invariant
violations mentioned there do not occur here.

Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Daniel P. Berrangé <berrange@redhat.com>
Cc: Eduardo Habkost <eduardo@habkost.net>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
  hw/acpi/memory_hotplug.c    | 2 +-
  hw/core/qdev.c              | 2 +-
  hw/ppc/spapr.c              | 2 +-
  hw/ppc/spapr_drc.c          | 3 +--
  qom/qom-qmp-cmds.c          | 7 +------
  stubs/qdev.c                | 6 ++----
  tests/qtest/fuzz/qos_fuzz.c | 3 +--
  scripts/qapi/schema.py      | 2 --
  8 files changed, 8 insertions(+), 19 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]