qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests/qtest/ac97-test: add up-/downsampling tests


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] tests/qtest/ac97-test: add up-/downsampling tests
Date: Fri, 4 Nov 2022 18:56:18 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1

On 4/11/22 18:33, Thomas Huth wrote:
On 26/10/2022 21.34, Volker Rümelin wrote:
Am 25.10.22 um 09:44 schrieb Marc-André Lureau:
Hi

On Tue, Oct 25, 2022 at 12:31 AM Volker Rümelin<vr_qemu@t-online.de> wrote:
Am 24.10.22 um 10:13 schrieb Marc-André Lureau:
Hi

On Mon, Oct 24, 2022 at 9:28 AM Volker Rümelin<vr_qemu@t-online.de>
wrote:

     Test if the audio subsystem can handle extreme up- and down-
     sampling ratios like 44100/1 and 1/44100. For some time these
     used to trigger QEMU aborts. The test was taken from
     https://gitlab.com/qemu-project/qemu/-/issues/71  where it was
     used to demonstrate a very different issue.

     Suggested-by: Marc-André Lureau<marcandre.lureau@redhat.com>
     Signed-off-by: Volker Rümelin<vr_qemu@t-online.de>


Thanks for working on this

It seems to show something different though:
"
A bug was just triggered in audio_calloc
Save all your work and restart without audio
I am sorry
"

AUD_open_out() is called with audsettings: {freq = 1, nchannels = 2,
fmt = AUDIO_FORMAT_S16, endianness = 0}

And that's it. Any idea?
Hi,

the scary message is expected and doesn't mean this qos-test failed.
This is the currently not so silent 'the audio subsystem should (...)
silently give up' case.
Ok, but it's not silent. According to the AC97 spec, "if the value
written to the register is supported that value will be echoed back
when read, otherwise the closest (higher in case of a tie) sample rate
supported is returned". We should probably pick a low sample rate,
like 8000 (see Table 32 in spec 2.1) for anything below it.

Hi,

I don't think we should limit the lowest sample rate to 8000 Hz. The sample rates in AC97 revision 2.1 Table 32 are sample rates the codec should support at minimum. We are free to support the whole 1-65535 Hz sample rate range.

FWIW, a minimum sample rate of 1 Hz also does not make much sense. You cannot hear that frequency anymore... so it does not really make that much sense to support such low frequencies here. Just my 0.02 €.

Still useful when using a sound card as signal generator, i.e.:
https://www.allaboutcircuits.com/technical-articles/how-to-use-your-computer-as-an-arbitrary-waveform-generator/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]