Re: [PULL v2 00/82] pci,pc,virtio: features, tests, fixes, cleanups

[Daniel P . Berrangé]

On Thu, Nov 03, 2022 at 04:47:03PM +0000, Peter Maydell wrote:
> On Thu, 3 Nov 2022 at 16:38, Daniel P. Berrangé <berrange@redhat.com> wrote:
> > On Thu, Nov 03, 2022 at 12:25:49PM -0400, Stefan Hajnoczi wrote:
> > > 2. The GitLab output does not contain the full command lines because
> > > environment variables are hidden (e.g. $QEMU_CONFIGURE_OPTS).
> >
> > Note, $QEMU_CONFIGURE_OPTS is set by the container image itself, so
> > there's no need to know that one.
> >
> > $CONFIGURE_ARGS meanwhile is set in the build-XXXXX template and
> > easy to find.
> 
> Not all that easy if you're looking at some specific gitlab
> job output... it would be helpful if the scripts
> echoed the exact configure command line before running it,
> then you wouldn't need to go ferreting around in the gitlab
> config files and hoping you've found the right bit.

That's easy enough to do, I'll send a patch.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|