Re: [PATCH RFC 2/4] hmp: Add "info netdev" cmd

[Thomas Huth]

On 31/10/2022 17.19, huangy81@chinatelecom.cn wrote:
> From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
>
> Introduce "info netdev" command so developers can play with
> it easier.
>
> Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
> ---
>   hmp-commands-info.hx  | 14 ++++++++++++++
>   include/monitor/hmp.h |  1 +
>   net/net.c             | 31 +++++++++++++++++++++++++++++++
>   3 files changed, 46 insertions(+)
>
> diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx
> index 754b1e8..217843c 100644
> --- a/hmp-commands-info.hx
> +++ b/hmp-commands-info.hx
> @@ -880,6 +880,20 @@ SRST
>       Display the vcpu dirty page limit information.
>   ERST
>   
> +    {
> +        .name       = "netdev",
> +        .args_type  = "",
> +        .params     = "",
> +        .help       = "show information about netdev, guest acked features are 
> "
> +                      "also printed if supporting virtio-net dataplane 
> offloading",
> +        .cmd        = hmp_info_netdev,
> +    },
> +
> +SRST
> +  ``info netdev``
> +    Display information about netdev.
> +ERST

Hmm, so according to the information, this shows information about the 
virtio *frontend*, but netdev is about *backends* (like TAP, slirp, VDE, 
...) ... so this is definitely also the wrong naming here. Maybe rather 
"info virtio-net" or "info vhost-net" or something like that?

 Thomas