[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] file-posix: fix Linux alignment probing when EIO is retu
From: |
Eric Biggers |
Subject: |
Re: [PATCH 1/2] file-posix: fix Linux alignment probing when EIO is returned |
Date: |
Tue, 1 Nov 2022 19:27:14 -0700 |
On Tue, Nov 01, 2022 at 03:00:30PM -0400, Stefan Hajnoczi wrote:
> Linux dm-crypt returns errno EIO from unaligned O_DIRECT pread(2) calls.
Citation needed. For direct I/O to block devices, the kernel's block layer
checks the alignment before the I/O is actually submitted to the underlying
block device. See
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/block/fops.c?h=v6.1-rc3#n306
> Buglink: https://gitlab.com/qemu-project/qemu/-/issues/1290
That "bug" seems to be based on a misunderstanding of the kernel source code,
and not any actual testing.
I just tested it, and the error code is EINVAL.
- Eric
- [PATCH 0/2] file-posix: alignment probing improvements, Stefan Hajnoczi, 2022/11/01
- [PATCH 2/2] file-posix: add statx(STATX_DIOALIGN) support, Stefan Hajnoczi, 2022/11/01
- [PATCH 1/2] file-posix: fix Linux alignment probing when EIO is returned, Stefan Hajnoczi, 2022/11/01
- Re: [PATCH 1/2] file-posix: fix Linux alignment probing when EIO is returned,
Eric Biggers <=
- Re: [PATCH 1/2] file-posix: fix Linux alignment probing when EIO is returned, Eric Biggers, 2022/11/01
- Re: [PATCH 1/2] file-posix: fix Linux alignment probing when EIO is returned, Stefan Hajnoczi, 2022/11/02
- Re: [PATCH 1/2] file-posix: fix Linux alignment probing when EIO is returned, Kevin Wolf, 2022/11/03
- Re: [PATCH 1/2] file-posix: fix Linux alignment probing when EIO is returned, Stefan Hajnoczi, 2022/11/03
- Re: [PATCH 1/2] file-posix: fix Linux alignment probing when EIO is returned, Eric Biggers, 2022/11/03
- Re: [PATCH 1/2] file-posix: fix Linux alignment probing when EIO is returned, Eric Biggers, 2022/11/03
- Re: [PATCH 1/2] file-posix: fix Linux alignment probing when EIO is returned, Stefan Hajnoczi, 2022/11/03