qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 08/30] target/arm: Add ptw_idx to S1Translate


From: Philippe Mathieu-Daudé
Subject: Re: [PULL 08/30] target/arm: Add ptw_idx to S1Translate
Date: Tue, 1 Nov 2022 17:57:16 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.0

On 1/11/22 11:10, Philippe Mathieu-Daudé wrote:
On 1/11/22 00:14, Philippe Mathieu-Daudé wrote:
On 25/10/22 18:39, Peter Maydell wrote:
From: Richard Henderson <richard.henderson@linaro.org>

Hoist the computation of the mmu_idx for the ptw up to
get_phys_addr_with_struct and get_phys_addr_twostage.
This removes the duplicate check for stage2 disabled
from the middle of the walk, performing it only once.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Alex Bennée <alex.bennee@linaro.org>
Message-id: 20221024051851.3074715-3-richard.henderson@linaro.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
  target/arm/ptw.c | 71 ++++++++++++++++++++++++++++++++++++------------
  1 file changed, 54 insertions(+), 17 deletions(-)

Since this commit I can not boot Trusted Firmware on the SBSA-ref machine.

Do we need to set in_ptw_idx in get_phys_addr_with_secure()?

I opened https://gitlab.com/qemu-project/qemu/-/issues/1293 to track.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]