Re: HMAT patches failure (was Re: [PULL 00/86] pci,pc,virtio: features, tests, fixes, cleanups)

[Jonathan Cameron]

On Tue, 1 Nov 2022 06:32:05 -0400
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Mon, Oct 31, 2022 at 04:06:03PM -0400, Stefan Hajnoczi wrote:
> > Here is another CI failure:
> > 
> > qemu-system-i386: current -smp configuration requires kernel irqchip
> > and X2APIC API support.
> > Broken pipe
> > ../tests/qtest/libqtest.c:179: kill_qemu() tried to terminate QEMU
> > process but encountered exit status 1 (expected 0)
> > TAP parsing error: Too few tests run (expected 49, got 22)

Got a bit thrown by this which is unrelated to the HMAT series.  Given I 
bisected it...

   bios-tables-test: add test for number of cores > 255
seems to be issue.  I'll take a look into why shortly.


> > (test program exited with status code -6)
> > ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
> > 6/202 qemu:qtest+qtest-i386 / qtest-i386/test-hmp OK 7.46s 9 subtests passed
> > ▶ 7/202 ERROR:../tests/qtest/bios-tables-test.c:533:test_acpi_asl:
> > assertion failed: (all_tables_match) ERROR
> > 7/202 qemu:qtest+qtest-aarch64 / qtest-aarch64/bios-tables-test ERROR
> > 108.34s killed by signal 6 SIGABRT  
> > >>> G_TEST_DBUS_DAEMON=/builds/qemu-project/qemu/tests/dbus-vmstate-daemon.sh
> > >>>  QTEST_QEMU_BINARY=./qemu-system-aarch64 MALLOC_PERTURB_=89 
> > >>> /builds/qemu-project/qemu/build/tests/qtest/bios-tables-test --tap -k  
> > ――――――――――――――――――――――――――――――――――――― ✀ 
> > ―――――――――――――――――――――――――――――――――――――
> > stderr:
> > acpi-test: Warning! APIC binary file mismatch. Actual
> > [aml:/tmp/aml-UKB6U1], Expected
> > [aml:tests/data/acpi/virt/APIC.acpihmatvirt].
> > See source file tests/qtest/bios-tables-test.c for instructions on how
> > to update expected files.
> > to see ASL diff between mismatched files install IASL, rebuild QEMU
> > from scratch and re-run tests with V=1 environment variable set**
> > ERROR:../tests/qtest/bios-tables-test.c:533:test_acpi_asl: assertion
> > failed: (all_tables_match)

Ah. I'd failed to notice you said to drop first patch. Now replicating.
Looks like the tables introduced for HMAT need updating to take into account
changes made earlier in your pull request (version numbers etc)


Jonathan

> > (test program exited with status code -6)
> > 
> > https://gitlab.com/qemu-project/qemu/-/jobs/3253817453  
> 
> 
> Hesham Jonathan pls take a look, if you post a fixup today
> or early tomorrow I can squash it
> and then this patchset can still be included in the release.
> 
> Thanks!
>