qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 2/5] tests: virt: update expected ACPI tables for virt tes


From: Yicong Yang
Subject: Re: [PATCH v3 2/5] tests: virt: update expected ACPI tables for virt test
Date: Mon, 31 Oct 2022 20:48:21 +0800
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1

Hi Michael and Yanan,

On 2022/10/31 20:30, Michael S. Tsirkin wrote:
> On Mon, Oct 31, 2022 at 07:21:31PM +0800, wangyanan (Y) wrote:
>> Hi Yicong,
>>
>> On 2022/10/31 17:05, Yicong Yang wrote:
>>> From: Yicong Yang <yangyicong@hisilicon.com>
>>>
>>> Update the ACPI tables according to the acpi aml_build change.
>> We may also need the disassembled context of the table change
> 
> and it's not a "maybe need". We do need it.
> 

Got it. Let me check and attach these diff informations for all the
test table changes in this series. Thanks for the guidance!

Thanks.

>> in the commit message, for review.
>>
>> For your reference: see patch 6 in [1]:
>> https://patchew.org/QEMU/20220107083232.16256-1-wangyanan55@huawei.com/
>>
>> Thanks,
>> Yanan
>>> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>>> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
>>> ---
>>>   tests/data/acpi/virt/PPTT                   | Bin 96 -> 76 bytes
>>>   tests/qtest/bios-tables-test-allowed-diff.h |   1 -
>>>   2 files changed, 1 deletion(-)
>>>
>>> diff --git a/tests/data/acpi/virt/PPTT b/tests/data/acpi/virt/PPTT
>>> index 
>>> f56ea63b369a604877374ad696c396e796ab1c83..7a1258ecf123555b24462c98ccbb76b4ac1d0c2b
>>>  100644
>>> GIT binary patch
>>> delta 32
>>> fcmYfB;R*-{3GrcIU|?D?k;`ae01J-_kOKn%ZFdCM
>>>
>>> delta 53
>>> pcmeZC;0g!`2}xjJU|{l?$YrDgWH5jU5Ca567#O&Klm(arApowi1QY-O
>>>
>>> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h 
>>> b/tests/qtest/bios-tables-test-allowed-diff.h
>>> index cb143a55a6..dfb8523c8b 100644
>>> --- a/tests/qtest/bios-tables-test-allowed-diff.h
>>> +++ b/tests/qtest/bios-tables-test-allowed-diff.h
>>> @@ -1,2 +1 @@
>>>   /* List of comma-separated changed AML files to ignore */
>>> -"tests/data/acpi/virt/PPTT",
> 
> .
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]