[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 24/26] qemu-sockets: update socket_uri() and socket_parse() to be
From: |
Jason Wang |
Subject: |
[PULL 24/26] qemu-sockets: update socket_uri() and socket_parse() to be consistent |
Date: |
Fri, 28 Oct 2022 13:48:33 +0800 |
From: Laurent Vivier <lvivier@redhat.com>
To be consistent with socket_uri(), add 'tcp:' prefix for inet type in
socket_parse(), by default socket_parse() use tcp when no prefix is
provided (format is host:port).
In socket_uri(), use 'vsock:' prefix for vsock type rather than 'tcp:'
because it makes a vsock address look like an inet address with CID
misinterpreted as host.
Goes back to commit 9aca82ba31 "migration: Create socket-address parameter"
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
util/qemu-sockets.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
index 9f6f655..a9926af 100644
--- a/util/qemu-sockets.c
+++ b/util/qemu-sockets.c
@@ -1090,7 +1090,7 @@ char *socket_uri(SocketAddress *addr)
case SOCKET_ADDRESS_TYPE_FD:
return g_strdup_printf("fd:%s", addr->u.fd.str);
case SOCKET_ADDRESS_TYPE_VSOCK:
- return g_strdup_printf("tcp:%s:%s",
+ return g_strdup_printf("vsock:%s:%s",
addr->u.vsock.cid,
addr->u.vsock.port);
default:
@@ -1124,6 +1124,11 @@ SocketAddress *socket_parse(const char *str, Error
**errp)
if (vsock_parse(&addr->u.vsock, str + strlen("vsock:"), errp)) {
goto fail;
}
+ } else if (strstart(str, "tcp:", NULL)) {
+ addr->type = SOCKET_ADDRESS_TYPE_INET;
+ if (inet_parse(&addr->u.inet, str + strlen("tcp:"), errp)) {
+ goto fail;
+ }
} else {
addr->type = SOCKET_ADDRESS_TYPE_INET;
if (inet_parse(&addr->u.inet, str, errp)) {
--
2.7.4
- [PULL 14/26] qapi: net: introduce a way to bypass qemu_opts_parse_noisily(), (continued)
- [PULL 14/26] qapi: net: introduce a way to bypass qemu_opts_parse_noisily(), Jason Wang, 2022/10/28
- [PULL 15/26] net: introduce qemu_set_info_str() function, Jason Wang, 2022/10/28
- [PULL 16/26] qapi: net: add stream and dgram netdevs, Jason Wang, 2022/10/28
- [PULL 17/26] net: socket: Don't ignore EINVAL on netdev socket connection, Jason Wang, 2022/10/28
- [PULL 18/26] net: stream: Don't ignore EINVAL on netdev socket connection, Jason Wang, 2022/10/28
- [PULL 19/26] net: stream: add unix socket, Jason Wang, 2022/10/28
- [PULL 20/26] net: dgram: make dgram_dst generic, Jason Wang, 2022/10/28
- [PULL 21/26] net: dgram: move mcast specific code from net_socket_fd_init_dgram(), Jason Wang, 2022/10/28
- [PULL 22/26] net: dgram: add unix socket, Jason Wang, 2022/10/28
- [PULL 25/26] net: stream: move to QIO to enable additional parameters, Jason Wang, 2022/10/28
- [PULL 24/26] qemu-sockets: update socket_uri() and socket_parse() to be consistent,
Jason Wang <=
- [PULL 23/26] qemu-sockets: move and rename SocketAddress_to_str(), Jason Wang, 2022/10/28
- [PULL 26/26] net: stream: add QAPI events to report connection state, Jason Wang, 2022/10/28
- Re: [PULL 00/26] Net patches, Stefan Hajnoczi, 2022/10/31