[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 03/11] dump: Reorder struct DumpState
From: |
marcandre . lureau |
Subject: |
[PULL v2 03/11] dump: Reorder struct DumpState |
Date: |
Tue, 25 Oct 2022 11:49:55 +0400 |
From: Janosch Frank <frankja@linux.ibm.com>
Let's move ELF related members into one block and guest memory related
ones into another to improve readability.
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20221017083822.43118-4-frankja@linux.ibm.com>
---
include/sysemu/dump.h | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/include/sysemu/dump.h b/include/sysemu/dump.h
index 9995f65dc8..9ed811b313 100644
--- a/include/sysemu/dump.h
+++ b/include/sysemu/dump.h
@@ -154,15 +154,8 @@ typedef struct DumpState {
GuestPhysBlockList guest_phys_blocks;
ArchDumpInfo dump_info;
MemoryMappingList list;
- uint32_t phdr_num;
- uint32_t shdr_num;
bool resume;
bool detached;
- ssize_t note_size;
- hwaddr shdr_offset;
- hwaddr phdr_offset;
- hwaddr section_offset;
- hwaddr note_offset;
hwaddr memory_offset;
int fd;
@@ -177,6 +170,15 @@ typedef struct DumpState {
int64_t filter_area_begin; /* Start address of partial guest memory area
*/
int64_t filter_area_length; /* Length of partial guest memory area */
+ /* Elf dump related data */
+ uint32_t phdr_num;
+ uint32_t shdr_num;
+ ssize_t note_size;
+ hwaddr shdr_offset;
+ hwaddr phdr_offset;
+ hwaddr section_offset;
+ hwaddr note_offset;
+
void *elf_section_hdrs; /* Pointer to section header buffer */
uint8_t *note_buf; /* buffer for notes */
--
2.37.3
- [PULL v2 00/11] Dump patches, marcandre . lureau, 2022/10/25
- [PULL v2 01/11] dump: Use a buffer for ELF section data and headers, marcandre . lureau, 2022/10/25
- [PULL v2 03/11] dump: Reorder struct DumpState,
marcandre . lureau <=
- [PULL v2 04/11] dump: Reintroduce memory_offset and section_offset, marcandre . lureau, 2022/10/25
- [PULL v2 10/11] s390x: pv: Add dump support, marcandre . lureau, 2022/10/25
- [PULL v2 02/11] dump: Write ELF section headers right after ELF header, marcandre . lureau, 2022/10/25
- [PULL v2 05/11] dump: Add architecture section and section string table support, marcandre . lureau, 2022/10/25
- [PULL v2 08/11] include/elf.h: add s390x note types, marcandre . lureau, 2022/10/25
- [PULL v2 06/11] s390x: Add protected dump cap, marcandre . lureau, 2022/10/25
- [PULL v2 09/11] s390x: Add KVM PV dump interface, marcandre . lureau, 2022/10/25
- [PULL v2 07/11] s390x: Introduce PV query interface, marcandre . lureau, 2022/10/25
- [PULL v2 11/11] dump/win_dump: limit number of processed PRCBs, marcandre . lureau, 2022/10/25
- Re: [PULL v2 00/11] Dump patches, Stefan Hajnoczi, 2022/10/25