[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] hw/block/nvme: add ZONE_FINISH_RECOMMENDED functionality
From: |
Klaus Jensen |
Subject: |
Re: [PATCH 1/4] hw/block/nvme: add ZONE_FINISH_RECOMMENDED functionality |
Date: |
Fri, 21 Oct 2022 08:36:36 +0200 |
On Oct 20 17:18, clay.mayers@kioxia.com wrote:
> From: Clay Mayers <clay.mayers@kioxia.com>
>
> Adds ns.param.zoned.finish_time, which sets the number of
> seconds a zone can remain active before the zone attribute
> ZONE_FINISH_RECOMMENDED is set.
>
> This requires scanning the exp open, imp open and closed lists
> of zones whenever a zone is marked as requiring finishing. The
> expectation is these lists will be short (10s of items) allowing a
> simpler implementation than keeping the lists sorted. It also
> keeps the overhead during the exception of a timeout instead of
> when zones change state between open and closed. For use cases
> where this isn't true, finish_time should be 0 to disable this
> feature (the default).
>
> Signed-off-by: Clay Mayers <clay.mayers@kioxia.com>
> ---
> docs/system/devices/nvme.rst | 5 +++++
> hw/nvme/ctrl.c | 35 +++++++++++++++++++++++++++++++++++
> hw/nvme/ns.c | 8 ++++++++
> hw/nvme/nvme.h | 18 ++++++++++++++----
> 4 files changed, 62 insertions(+), 4 deletions(-)
>
Single timer? Check.
LGTM.
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
signature.asc
Description: PGP signature
- [PATCH 0/4] hw/block/nvme: Implement ZNS finish-zone ZDC AEN, clay.mayers, 2022/10/20
- [PATCH 1/4] hw/block/nvme: add ZONE_FINISH_RECOMMENDED functionality, clay.mayers, 2022/10/20
- Re: [PATCH 1/4] hw/block/nvme: add ZONE_FINISH_RECOMMENDED functionality,
Klaus Jensen <=
- [PATCH 2/4] hw/block/nvme: add zone descriptor changed log page, clay.mayers, 2022/10/20
- [PATCH 4/4] hw/block/nvme: add zone descriptor changed AEN, clay.mayers, 2022/10/20
- [PATCH 3/4] hw/block/nvme: supply dw1 for aen result, clay.mayers, 2022/10/20
- Re: [PATCH 0/4] hw/block/nvme: Implement ZNS finish-zone ZDC AEN, Klaus Jensen, 2022/10/21