Re: [PATCH v4 00/10] Introduce new acpi/smbios avocado tests using biosbits

[Ani Sinha]

On Wed, Oct 19, 2022 at 11:52 AM Thomas Huth <thuth@redhat.com> wrote:
>
> On 18/10/2022 17.34, Ani Sinha wrote:
> > On Tue, Oct 18, 2022 at 9:01 PM Alex Bennée <alex.bennee@linaro.org> wrote:
> >>
> >>
> >> Ani Sinha <ani@anisinha.ca> writes:
> >>
> >>> Please see the README file in patch 9 for more details.
> >>> Sample runs are as follows:
> >>>
> >>> Passed tests:
> >>>
> >>> $ ./tests/venv/bin/avocado run -t acpi tests/avocado
> >>> Fetching asset from 
> >>> tests/avocado/acpi-bits.py:AcpiBitsTest.test_acpi_smbios_bits
> >>> JOB ID     : e95c7413e996bfb59389839e5ca5105464ef098f
> >>> JOB LOG    : 
> >>> /home/anisinha/avocado/job-results/job-2022-10-14T19.15-e95c741/job.log
> >>>   (1/1) tests/avocado/acpi-bits.py:AcpiBitsTest.test_acpi_smbios_bits: 
> >>> PASS (33.08 s)
> >>> RESULTS    : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | 
> >>> CANCEL 0
> >>> JOB TIME   : 39.18 s
> >>
> >> Hmm something went wrong:
> >>
> >>    ➜  ./tests/venv/bin/avocado run -t acpi tests/avocado
> >>    Fetching asset from 
> >> tests/avocado/acpi-bits.py:AcpiBitsTest.test_acpi_smbios_bits
> >>    JOB ID     : 08b6d26bf52a22ccbe1908b14d5b7b27f76ad7fa
> >>    JOB LOG    : 
> >> /home/alex/avocado/job-results/job-2022-10-18T16.29-08b6d26/job.log
> >>     (1/1) tests/avocado/acpi-bits.py:AcpiBitsTest.test_acpi_smbios_bits: 
> >> ERROR: Error while generating the bits iso. Pass V=1 in the environment to 
> >> get more details. Command '[
> >>    
> >> '/var/tmp/acpi-bits-yy4mfxrz.tmp/grub-inst-x86_64-efi/bin/grub-mkrescue', 
> >> '-o', '/var/tmp/acpi-bits-yy4mfxrz.tmp/bits-2020.iso', 
> >> '/var/tmp/acpi-bits-yy4mfxrz.t... (7.21 s)
> >>    RESULTS    : PASS 0 | ERROR 1 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 
> >> | CANCEL 0
> >>    JOB TIME   : 7.79 s
> >>
> >> have we added another binary dependency?
> >
> > Try with V=1 , Maybe you do not have xorriso? If that is the case, you
> > need to install it in your test environment.
>
> If a tool is missing, the test should be SKIP and not ERROR, I think?

Yes check v5. I have added the skip.