[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [BUG] hw/i386/pc.c: CXL Fixed Memory Window should not reserve e820
From: |
Gregory Price |
Subject: |
Re: [BUG] hw/i386/pc.c: CXL Fixed Memory Window should not reserve e820 in bios |
Date: |
Tue, 18 Oct 2022 10:49:46 -0400 |
> > - e820_add_entry(cxl_base, cxl_size, E820_RESERVED);
> > memory_region_init(mr, OBJECT(machine), "cxl_host_reg", cxl_size);
> > memory_region_add_subregion(system_memory, cxl_base, mr);
> > cxl_resv_end = cxl_base + cxl_size;
> > @@ -1077,7 +1076,6 @@ void pc_memory_init(PCMachineState *pcms,
> > memory_region_init_io(&fw->mr, OBJECT(machine),
> > &cfmws_ops, fw,
> > "cxl-fixed-memory-region",
> > fw->size);
> > memory_region_add_subregion(system_memory, fw->base,
> > &fw->mr);
>
> Or will this be subregion of cxl_base?
>
> Thanks,
> Pankaj
The memory region backing this memory area still has to be initialized
and added in the QEMU system, but it will now be initialized for use by
linux after PCI/ACPI setup occurs and the CXL driver discovers it via
CDAT.
It's also still possible to assign this area a static memory region at
bool by setting up the SRATs in the ACPI tables, but that patch is not
upstream yet.