[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 22/28] qapi stats: Elide redundant has_FOO in generated C
From: |
Markus Armbruster |
Subject: |
[PATCH v2 22/28] qapi stats: Elide redundant has_FOO in generated C |
Date: |
Tue, 18 Oct 2022 08:28:43 +0200 |
The has_FOO for pointer-valued FOO are redundant, except for arrays.
They are also a nuisance to work with. Recent commit "qapi: Start to
elide redundant has_FOO in generated C" provided the means to elide
them step by step. This is the step for qapi/stats.json.
Said commit explains the transformation in more detail. The invariant
violations mentioned there do not occur here.
Cc: Mark Kanda <mark.kanda@oracle.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Mark Kanda <mark.kanda@oracle.com>
---
monitor/qmp-cmds.c | 5 +----
scripts/qapi/schema.py | 1 -
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/monitor/qmp-cmds.c b/monitor/qmp-cmds.c
index 2a0c919472..e3734f1946 100644
--- a/monitor/qmp-cmds.c
+++ b/monitor/qmp-cmds.c
@@ -563,10 +563,7 @@ void add_stats_entry(StatsResultList **stats_results,
StatsProvider provider,
StatsResult *entry = g_new0(StatsResult, 1);
entry->provider = provider;
- if (qom_path) {
- entry->has_qom_path = true;
- entry->qom_path = g_strdup(qom_path);
- }
+ entry->qom_path = g_strdup(qom_path);
entry->stats = stats_list;
QAPI_LIST_PREPEND(*stats_results, entry);
diff --git a/scripts/qapi/schema.py b/scripts/qapi/schema.py
index f405ab7f49..0544037e71 100644
--- a/scripts/qapi/schema.py
+++ b/scripts/qapi/schema.py
@@ -759,7 +759,6 @@ def need_has(self):
assert self.type
# Temporary hack to support dropping the has_FOO in reviewable chunks
opt_out = [
- 'qapi/stats.json',
'qapi/tpm.json',
'qapi/transaction.json',
'qapi/ui.json',
--
2.37.2
- [PATCH v2 00/28] qapi: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/10/18
- [PATCH v2 16/28] qapi net: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/10/18
- [PATCH v2 10/28] qapi crypto: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/10/18
- [PATCH v2 13/28] qapi machine: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/10/18
- [PATCH v2 09/28] qapi char: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/10/18
- [PATCH v2 22/28] qapi stats: Elide redundant has_FOO in generated C,
Markus Armbruster <=
- [PATCH v2 25/28] qapi ui: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/10/18
- [PATCH v2 07/28] qapi audio: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/10/18
- [PATCH v2 24/28] qapi transaction: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/10/18
- [PATCH v2 27/28] qapi qga: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/10/18
- [PATCH v2 06/28] qapi acpi: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/10/18
- [PATCH v2 02/28] qapi: Tidy up whitespace in generated code, Markus Armbruster, 2022/10/18
- [PATCH v2 03/28] docs/devel/qapi-code-gen: Extend example for next commit's change, Markus Armbruster, 2022/10/18
- [PATCH v2 17/28] qapi pci: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/10/18