qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] target/s390x: Fix emulation of the VISTR instruction


From: Richard Henderson
Subject: Re: [PATCH] target/s390x: Fix emulation of the VISTR instruction
Date: Tue, 11 Oct 2022 09:39:36 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2

On 10/11/22 06:24, David Hildenbrand wrote:
+++ b/tests/tcg/s390x/vf.c

In general, we use "vx" when talking about vector extension. Maybe name this
vx.c

Ok... or maybe "vecstring.c" in case we only want to test the vector string
functions here? (they are in a separate chapter in the PoP)

Also works for me. Or "vx_str.c" or sth like that.

If we're going to bikeshed the name, use the insn being tested.

What you don't want is one big file testing lots of things.
What you do want is lots of little files each testing one thing.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]