[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 15/55] tests/qtest: plain g_assert for VHOST_USER_F_PROTOCOL_FEATU
From: |
Michael S. Tsirkin |
Subject: |
[PULL 15/55] tests/qtest: plain g_assert for VHOST_USER_F_PROTOCOL_FEATURES |
Date: |
Mon, 10 Oct 2022 13:29:43 -0400 |
From: Alex Bennée <alex.bennee@linaro.org>
checkpatch.pl warns that non-plain asserts should be avoided so
convert the check to a plain g_assert.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20220802095010.3330793-19-alex.bennee@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
tests/qtest/vhost-user-test.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tests/qtest/vhost-user-test.c b/tests/qtest/vhost-user-test.c
index 8d2d4ba535..a99f55ed84 100644
--- a/tests/qtest/vhost-user-test.c
+++ b/tests/qtest/vhost-user-test.c
@@ -985,8 +985,7 @@ static void test_multiqueue(void *obj, void *arg,
QGuestAllocator *alloc)
static void vu_net_set_features(TestServer *s, CharBackend *chr,
VhostUserMsg *msg)
{
- g_assert_cmpint(msg->payload.u64 &
- (0x1ULL << VHOST_USER_F_PROTOCOL_FEATURES), !=, 0ULL);
+ g_assert(msg->payload.u64 & (0x1ULL << VHOST_USER_F_PROTOCOL_FEATURES));
if (s->test_flags == TEST_FLAGS_DISCONNECT) {
qemu_chr_fe_disconnect(chr);
s->test_flags = TEST_FLAGS_BAD;
--
MST
- Re: Regression save/restore of vsock: (was [PULL 07/55] hw/virtio: move vm_running check to virtio_device_started), (continued)
[PULL 08/55] hw/virtio: move vhd->started check into helper and add FIXME, Michael S. Tsirkin, 2022/10/10
[PULL 09/55] hw/virtio: add boilerplate for vhost-user-gpio device, Michael S. Tsirkin, 2022/10/10
[PULL 10/55] hw/virtio: add vhost-user-gpio-pci boilerplate, Michael S. Tsirkin, 2022/10/10
[PULL 11/55] tests/qtest: pass stdout/stderr down to subtests, Michael S. Tsirkin, 2022/10/10
[PULL 12/55] tests/qtest: add a timeout for subprocess_run_one_test, Michael S. Tsirkin, 2022/10/10
[PULL 13/55] tests/qtest: use qos_printf instead of g_test_message, Michael S. Tsirkin, 2022/10/10
[PULL 14/55] tests/qtest: catch unhandled vhost-user messages, Michael S. Tsirkin, 2022/10/10
[PULL 15/55] tests/qtest: plain g_assert for VHOST_USER_F_PROTOCOL_FEATURES,
Michael S. Tsirkin <=
[PULL 16/55] tests/qtest: add assert to catch bad features, Michael S. Tsirkin, 2022/10/10
[PULL 17/55] tests/qtest: implement stub for VHOST_USER_GET_CONFIG, Michael S. Tsirkin, 2022/10/10
[PULL 18/55] tests/qtest: add a get_features op to vhost-user-test, Michael S. Tsirkin, 2022/10/10
[PULL 19/55] tests/qtest: enable tests for virtio-gpio, Michael S. Tsirkin, 2022/10/10
[PULL 20/55] virtio: introduce VirtIOConfigSizeParams & virtio_get_config_size, Michael S. Tsirkin, 2022/10/10
[PULL 21/55] virtio-blk: move config size params to virtio-blk-common, Michael S. Tsirkin, 2022/10/10
[PULL 22/55] vhost-user-blk: make it possible to disable write-zeroes/discard, Michael S. Tsirkin, 2022/10/10
[PULL 23/55] vhost-user-blk: make 'config_wce' part of 'host_features', Michael S. Tsirkin, 2022/10/10
[PULL 24/55] vhost-user-blk: dynamically resize config space based on features, Michael S. Tsirkin, 2022/10/10
[PULL 25/55] tests/acpi: virt: allow acpi GTDT changes, Michael S. Tsirkin, 2022/10/10