[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 05/18] block/vvfat: Unify the mkdir() call
From: |
Bin Meng |
Subject: |
[PATCH 05/18] block/vvfat: Unify the mkdir() call |
Date: |
Thu, 6 Oct 2022 23:11:22 +0800 |
From: Bin Meng <bin.meng@windriver.com>
There is a difference in the mkdir() call for win32 and non-win32
platforms, and currently is handled in the codes with #ifdefs.
glib provides a portable g_mkdir() API and we can use it to unify
the codes without #ifdefs.
Signed-off-by: Bin Meng <bin.meng@windriver.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
(no changes since v2)
Changes in v2:
- Change to use g_mkdir()
block/vvfat.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index d6dd919683..723beef025 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -25,6 +25,7 @@
#include "qemu/osdep.h"
#include <dirent.h>
+#include <glib/gstdio.h>
#include "qapi/error.h"
#include "block/block_int.h"
#include "block/qdict.h"
@@ -2726,13 +2727,9 @@ static int handle_renames_and_mkdirs(BDRVVVFATState* s)
mapping_t* mapping;
int j, parent_path_len;
-#ifdef __MINGW32__
- if (mkdir(commit->path))
+ if (g_mkdir(commit->path, 0755)) {
return -5;
-#else
- if (mkdir(commit->path, 0755))
- return -5;
-#endif
+ }
mapping = insert_mapping(s, commit->param.mkdir.cluster,
commit->param.mkdir.cluster + 1);
--
2.34.1
- [PATCH 00/18] tests/qtest: Enable running qtest on Windows, Bin Meng, 2022/10/06
- [PATCH 01/18] semihosting/arm-compat-semi: Avoid using hardcoded /tmp, Bin Meng, 2022/10/06
- [PATCH 03/18] util/qemu-sockets: Use g_get_tmp_dir() to get the directory for temporary files, Bin Meng, 2022/10/06
- [PATCH 02/18] tcg: Avoid using hardcoded /tmp, Bin Meng, 2022/10/06
- [PATCH 04/18] tests/qtest: migration-test: Avoid using hardcoded /tmp, Bin Meng, 2022/10/06
- [PATCH 05/18] block/vvfat: Unify the mkdir() call,
Bin Meng <=
- [PATCH 06/18] fsdev/virtfs-proxy-helper: Use g_mkdir(), Bin Meng, 2022/10/06
- [PATCH 07/18] hw/usb: dev-mtp: Use g_mkdir(), Bin Meng, 2022/10/06
- [PATCH 08/18] accel/qtest: Support qtest accelerator for Windows, Bin Meng, 2022/10/06
- [PATCH 09/18] tests/qtest: Use send/recv for socket communication, Bin Meng, 2022/10/06
- [PATCH 11/18] tests/qtest: Support libqtest to build and run on Windows, Bin Meng, 2022/10/06
- [PATCH 10/18] tests/qtest: libqtest: Install signal handler via signal(), Bin Meng, 2022/10/06
- [PATCH 14/18] io/channel-watch: Drop a superfluous '#ifdef WIN32', Bin Meng, 2022/10/06
- [PATCH 16/18] io/channel-watch: Fix socket watch on Windows, Bin Meng, 2022/10/06
- [PATCH 17/18] .gitlab-ci.d/windows.yml: Increase the timeout to 90 minutes, Bin Meng, 2022/10/06
- [PATCH 12/18] tests/qtest: migration-test: Make sure QEMU process "to" exited after migration is canceled, Bin Meng, 2022/10/06