Re: [PATCH v10 08/17] net: stream: Don't ignore EINVAL on netdev socket connection

[David Gibson]

On Wed, Oct 05, 2022 at 06:20:42PM +0200, Laurent Vivier wrote:
> From: Stefano Brivio <sbrivio@redhat.com>
> 
> Other errors are treated as failure by net_stream_client_init(),
> but if connect() returns EINVAL, we'll fail silently. Remove the
> related exception.
> 
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
> [lvivier: applied to net/stream.c]
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  net/stream.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/net/stream.c b/net/stream.c
> index 37965eb74e1a..26e485438718 100644
> --- a/net/stream.c
> +++ b/net/stream.c
> @@ -360,8 +360,7 @@ static int net_stream_client_init(NetClientState *peer,
>                  if (errno == EINTR || errno == EWOULDBLOCK) {
>                      /* continue */
>                  } else if (errno == EINPROGRESS ||
> -                           errno == EALREADY ||
> -                           errno == EINVAL) {
> +                           errno == EALREADY) {
>                      break;
>                  } else {
>                      error_setg_errno(errp, errno, "can't connect socket");

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature